From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 1/3] pinctrl: intel: Extract intel_pinctrl_get_soc_data() helper for wider use
Date: Tue, 18 Aug 2020 16:47:38 +0300 [thread overview]
Message-ID: <20200818134738.GR1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200818123602.GN1375436@lahna.fi.intel.com>
On Tue, Aug 18, 2020 at 03:36:02PM +0300, Mika Westerberg wrote:
> On Tue, Aug 18, 2020 at 03:34:59PM +0300, Andy Shevchenko wrote:
> > On Mon, Aug 03, 2020 at 04:50:31PM +0300, Andy Shevchenko wrote:
> > > On Mon, Aug 03, 2020 at 03:33:18PM +0300, Mika Westerberg wrote:
> > > > On Wed, Jul 29, 2020 at 02:57:06PM +0300, Andy Shevchenko wrote:
> > > > > intel_pinctrl_get_soc_data() helper can be used in few driver instead of
> > > > > open-coded variants. Thus, extract it as a standalone API.
> > >
> > > ...
> > >
> > > > > +const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct platform_device *pdev)
> > > >
> > > > Can we make this take const parameter as well?
> > >
> > > You mean
> > >
> > > const struct intel_pinctrl_soc_data *
> > > intel_pinctrl_get_soc_data(const struct platform_device *pdev)
> > >
> > > ?
> > >
> > > Sure, I can do it for v2.
> >
> > Actually I can't. device_match_data() requires struct device * pointer and
> > compiler is unable to compile with const qualifier.
>
> OK
>
> > Are you good with current version then?
>
> Yes :)
Pushed to my review and testing queue, thanks!
P.S. I have added your Ack as discussed offline.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-18 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 11:57 [PATCH v1 1/3] pinctrl: intel: Extract intel_pinctrl_get_soc_data() helper for wider use Andy Shevchenko
2020-07-29 11:57 ` [PATCH v1 2/3] pinctrl: baytrail: Switch to use intel_pinctrl_get_soc_data() Andy Shevchenko
2020-07-29 11:57 ` [PATCH v1 3/3] pinctrl: cherryview: " Andy Shevchenko
2020-08-03 12:33 ` [PATCH v1 1/3] pinctrl: intel: Extract intel_pinctrl_get_soc_data() helper for wider use Mika Westerberg
2020-08-03 13:50 ` Andy Shevchenko
2020-08-03 14:22 ` Mika Westerberg
2020-08-18 12:34 ` Andy Shevchenko
2020-08-18 12:36 ` Mika Westerberg
2020-08-18 13:47 ` Andy Shevchenko [this message]
2020-08-18 12:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818134738.GR1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).