From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D856C4332B for ; Wed, 6 Jan 2021 10:12:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15FDD23124 for ; Wed, 6 Jan 2021 10:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbhAFKMU (ORCPT ); Wed, 6 Jan 2021 05:12:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726770AbhAFKMT (ORCPT ); Wed, 6 Jan 2021 05:12:19 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A1BC061357 for ; Wed, 6 Jan 2021 02:11:39 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id a12so1874846wrv.8 for ; Wed, 06 Jan 2021 02:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o0MmhDNA3JbSjnUwo4vbVyBUWMBScjtNa0FqK3mxVOs=; b=TLaT5tZspuVGJZFrMHC8bGl0qbSPO+ECMvHJ4TiDeg1q3v+PceZlD+8SPNhsysjBgk tBBRgoiXtApQIJCJ58HMcbM/XYmcMtFNoxP8ZHnRTZkutvAzI7aC4XV8hjWDuBw6tSm/ TFhRoJ6uQxzrSJkhfBIjt+O3JsAh7PSY8SgUbN8gP8nWHcOp/uRcJrfcPTVRiBr9sMKe xZaN8cP9LJFbTTBVB7ZUudgGUNTaM+u1l7q7Kq2tMgh5wszhD6NuPMHnucvv+lXlTTwa zExSc9YfK5BD1Kk5r0B26T/9YW8Tr3SmHWwNkL6ZN3DnryVhPo11nkhsnR3DdtBEWd7L bwJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o0MmhDNA3JbSjnUwo4vbVyBUWMBScjtNa0FqK3mxVOs=; b=M7pI7iN0AZQcV8jsOUjOQTldnakQTGAKfVJFdML1FJsSt5A5ApESHJbffJvW5PLMvw Cd2AYrQ6Ch+jz6x+Rnk2Smo8lhWCaZuwygoh2eXlyLUotH9CiZOCyDEm8KS+kS4amBuB D5pxKxYWb0isBnrW26PukjNimOFc9b+qZTnh47TgYQj1VzwAVX2yAPluANbf9xFGJ+nY C94Hmu2ELXIey4qRZQgcFSAw7KxkAwh7i5uoOQIruixZykBxD3n186AnHozFd7x9TfOZ XR9oBi5MyY78Q6QyrpBG5nGKt9/1WoekhntVdJfM3GIQOxfk9ql8yGT/saFgA9//MMM2 c2iQ== X-Gm-Message-State: AOAM5303JvS1gO1AL1SCFg/qqE4Pv72wfLhqvRz3ZZ2mBSsnrnIjdl/J dF5FZnAJ6gtherwt/H1WNjWjvA== X-Google-Smtp-Source: ABdhPJw8NVN0Lxgf38SkFphNspwZgDglPoduNDrlf19AVkDO02vMAf1eEWYq48lSM6zhqccjQaleWg== X-Received: by 2002:a5d:4e8c:: with SMTP id e12mr3417456wru.321.1609927898267; Wed, 06 Jan 2021 02:11:38 -0800 (PST) Received: from localhost.localdomain (pop.92-184-102-148.mobile.abo.orange.fr. [92.184.102.148]) by smtp.gmail.com with ESMTPSA id r16sm2635656wrx.36.2021.01.06.02.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 02:11:37 -0800 (PST) From: Bartosz Golaszewski To: Matti Vaittinen , Linus Walleij , linux-power@fi.rohmeurope.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartosz Golaszewski Subject: [PATCH] gpio: bd7xxxx: use helper variable for pdev->dev Date: Wed, 6 Jan 2021 11:11:33 +0100 Message-Id: <20210106101133.18379-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Bartosz Golaszewski Using a helper local variable to store the address of &pdev->dev adds to readability and allows us to avoid unnecessary line breaks. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-bd70528.c | 17 ++++++++--------- drivers/gpio/gpio-bd71828.c | 15 +++++++-------- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/gpio/gpio-bd70528.c b/drivers/gpio/gpio-bd70528.c index 276a0fe6346d..397a50d6bc65 100644 --- a/drivers/gpio/gpio-bd70528.c +++ b/drivers/gpio/gpio-bd70528.c @@ -181,15 +181,15 @@ static int bd70528_gpio_get(struct gpio_chip *chip, unsigned int offset) static int bd70528_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct bd70528_gpio *bdgpio; int ret; - bdgpio = devm_kzalloc(&pdev->dev, sizeof(*bdgpio), - GFP_KERNEL); + bdgpio = devm_kzalloc(dev, sizeof(*bdgpio), GFP_KERNEL); if (!bdgpio) return -ENOMEM; - bdgpio->dev = &pdev->dev; - bdgpio->gpio.parent = pdev->dev.parent; + bdgpio->dev = dev; + bdgpio->gpio.parent = dev->parent; bdgpio->gpio.label = "bd70528-gpio"; bdgpio->gpio.owner = THIS_MODULE; bdgpio->gpio.get_direction = bd70528_get_direction; @@ -202,16 +202,15 @@ static int bd70528_probe(struct platform_device *pdev) bdgpio->gpio.ngpio = 4; bdgpio->gpio.base = -1; #ifdef CONFIG_OF_GPIO - bdgpio->gpio.of_node = pdev->dev.parent->of_node; + bdgpio->gpio.of_node = dev->parent->of_node; #endif - bdgpio->regmap = dev_get_regmap(pdev->dev.parent, NULL); + bdgpio->regmap = dev_get_regmap(dev->parent, NULL); if (!bdgpio->regmap) return -ENODEV; - ret = devm_gpiochip_add_data(&pdev->dev, &bdgpio->gpio, - bdgpio); + ret = devm_gpiochip_add_data(dev, &bdgpio->gpio, bdgpio); if (ret) - dev_err(&pdev->dev, "gpio_init: Failed to add bd70528-gpio\n"); + dev_err(dev, "gpio_init: Failed to add bd70528-gpio\n"); return ret; } diff --git a/drivers/gpio/gpio-bd71828.c b/drivers/gpio/gpio-bd71828.c index fcdcbb57c76d..c8e382b53f2f 100644 --- a/drivers/gpio/gpio-bd71828.c +++ b/drivers/gpio/gpio-bd71828.c @@ -97,15 +97,15 @@ static int bd71828_get_direction(struct gpio_chip *chip, unsigned int offset) static int bd71828_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct bd71828_gpio *bdgpio; - bdgpio = devm_kzalloc(&pdev->dev, sizeof(*bdgpio), - GFP_KERNEL); + bdgpio = devm_kzalloc(dev, sizeof(*bdgpio), GFP_KERNEL); if (!bdgpio) return -ENOMEM; - bdgpio->dev = &pdev->dev; - bdgpio->gpio.parent = pdev->dev.parent; + bdgpio->dev = dev; + bdgpio->gpio.parent = dev->parent; bdgpio->gpio.label = "bd71828-gpio"; bdgpio->gpio.owner = THIS_MODULE; bdgpio->gpio.get_direction = bd71828_get_direction; @@ -121,13 +121,12 @@ static int bd71828_probe(struct platform_device *pdev) * "gpio-reserved-ranges" and exclude them from control */ bdgpio->gpio.ngpio = 4; - bdgpio->gpio.of_node = pdev->dev.parent->of_node; - bdgpio->regmap = dev_get_regmap(pdev->dev.parent, NULL); + bdgpio->gpio.of_node = dev->parent->of_node; + bdgpio->regmap = dev_get_regmap(dev->parent, NULL); if (!bdgpio->regmap) return -ENODEV; - return devm_gpiochip_add_data(&pdev->dev, &bdgpio->gpio, - bdgpio); + return devm_gpiochip_add_data(dev, &bdgpio->gpio, bdgpio); } static struct platform_driver bd71828_gpio = { -- 2.29.1