From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43723C433FE for ; Thu, 6 Oct 2022 19:26:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231723AbiJFT05 (ORCPT ); Thu, 6 Oct 2022 15:26:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231965AbiJFT0t (ORCPT ); Thu, 6 Oct 2022 15:26:49 -0400 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8080B1144ED; Thu, 6 Oct 2022 12:26:43 -0700 (PDT) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-134072c15c1so104080fac.2; Thu, 06 Oct 2022 12:26:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LCfIAU4XMb60O7MjbbgmUxqie2tF6HVTSGKTzk1Ue+E=; b=y/z5fUXoU5lGDv3V2F8KQsYajZ8Ze8QXweL8/phAuI9NhKMbFrezIkmJxJSP9/XE45 tok+AJrpH31xMRtXfuV3/qLlLCJFntdh9o3aFqyM1ZKxerU2JHSes9ONO4/pm/VZI3Bd 4is4QC5COBSSvDX4lqJiSIrslk/gqMyC+zoumMnKYv1twcgC422bj9TMM3yMtEOnwp/X IHn8QAJnhqs2gl/tbdATUdk2fMZG2bbWm3A/PM/ClSVOUepOSnMdjA3OR7oc7njU8wuL hm9VVU36FtuRhMgra8DDWZX00dD/dd+1//PV7ymZKjeRYngwpc8FpZ9174AinD2VnQrf pfGg== X-Gm-Message-State: ACrzQf05bjY8GToqiNBxfX+ebG8RL2POsbYmCjeC4uynhUHKUDC11VbA 8wygv15De4+P7c/oSxlp0w== X-Google-Smtp-Source: AMsMyM5+kBzVXKb8H9EzrAFDhADJ7Hy2DKKeEGGr/zYiwPbbTryldTxJ9M2hbxNwHxbnQldxlJq8pA== X-Received: by 2002:a05:6870:5810:b0:127:a331:1e76 with SMTP id r16-20020a056870581000b00127a3311e76mr747672oap.292.1665084402259; Thu, 06 Oct 2022 12:26:42 -0700 (PDT) Received: from robh_at_kernel.org ([2607:fb90:8a65:c536:245:842:a3a4:9017]) by smtp.gmail.com with ESMTPSA id 127-20020a4a1185000000b0044df311eee1sm8038ooc.33.2022.10.06.12.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 12:26:41 -0700 (PDT) Received: (nullmailer pid 55788 invoked by uid 1000); Thu, 06 Oct 2022 19:26:39 -0000 Date: Thu, 6 Oct 2022 14:26:39 -0500 From: Rob Herring To: Yassine Oudjana Cc: Linus Walleij , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Andy Teng , AngeloGioacchino Del Regno , Yassine Oudjana , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 Message-ID: <20221006192639.GA49589-robh@kernel.org> References: <20221005174343.24240-1-y.oudjana@protonmail.com> <20221005174343.24240-7-y.oudjana@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221005174343.24240-7-y.oudjana@protonmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Oct 05, 2022 at 08:43:39PM +0300, Yassine Oudjana wrote: > From: Yassine Oudjana > > Combine MT6795 pin controller document into MT6779 one. In the > process, replace the current interrupts property description with > the one from the MT6795 document since it makes more sense. Also > amend property descriptions with more detailed information that > was available in the MT6795 document, and replace the current > pinmux node name patterns with ones from it since they are more > common across mediatek pin controller bindings. > > Signed-off-by: Yassine Oudjana > --- > .../pinctrl/mediatek,mt6779-pinctrl.yaml | 90 +++++-- > .../pinctrl/mediatek,pinctrl-mt6795.yaml | 225 ------------------ > 2 files changed, 73 insertions(+), 242 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > index a2141eb0854e..64d4b6a3b5bd 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > @@ -8,6 +8,7 @@ title: Mediatek MT6779 Pin Controller > > maintainers: > - Andy Teng > + - AngeloGioacchino Del Regno > - Sean Wang > > description: > @@ -18,6 +19,7 @@ properties: > compatible: > enum: > - mediatek,mt6779-pinctrl > + - mediatek,mt6795-pinctrl > - mediatek,mt6797-pinctrl > > reg: > @@ -43,9 +45,8 @@ properties: > interrupt-controller: true > > interrupts: > - maxItems: 1 minItems: 1 maxItems: 2 > description: | > - Specifies the summary IRQ. > + The interrupt output to sysirq. > > "#interrupt-cells": > const: 2 > @@ -81,6 +82,28 @@ allOf: > - const: iocfg_lt > - const: iocfg_tl > - const: eint > + > + interrupts: > + maxItems: 1 > + > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt6795-pinctrl > + then: > + properties: > + reg: > + minItems: 2 > + > + reg-names: > + items: > + - const: base > + - const: eint > + > + interrupts: > + minItems: 2 > + maxItems: 2 Just 'minItems: 2' > - if: > properties: > compatible: > @@ -111,32 +134,65 @@ allOf: > - "#interrupt-cells" > > patternProperties: > - '-[0-9]*$': > + '-pins$': > type: object > additionalProperties: false > > patternProperties: > - '-pins*$': > + '^pins': Seems like these 2 changes would break a bunch of cases. > type: object > description: | > A pinctrl node should contain at least one subnodes representing the > pinctrl groups available on the machine. Each subnode will list the > pins it needs, and how they should be configured, with regard to muxer > - configuration, pullups, drive strength, input enable/disable and input schmitt. > - $ref: "/schemas/pinctrl/pincfg-node.yaml" > + configuration, pullups, drive strength, input enable/disable and > + input schmitt. > + An example of using macro: > + pincontroller { > + /* GPIO0 set as multifunction GPIO0 */ > + gpio-pins { > + pins { > + pinmux = ; > + } > + }; > + /* GPIO45 set as multifunction SDA0 */ > + i2c0-pins { > + pins { > + pinmux = ; > + } > + }; > + }; Just put this in the actual example. > + $ref: "pinmux-node.yaml" > > properties: > pinmux: > description: > - integer array, represents gpio pin number and mux setting. > - Supported pin number and mux varies for different SoCs, and are defined > - as macros in boot/dts/-pinfunc.h directly. > + Integer array, represents gpio pin number and mux setting. > + Supported pin number and mux varies for different SoCs, and are > + defined as macros in dt-bindings/pinctrl/-pinfunc.h > + directly. > > bias-disable: true > > - bias-pull-up: true > - > - bias-pull-down: true > + bias-pull-up: > + oneOf: > + - type: boolean > + - enum: [100, 101, 102, 103] > + description: Pull up PUPD/R0/R1 type define value. > + description: | > + For normal pull up type, it is not necessary to specify R1R0 > + values; When pull up type is PUPD/R0/R1, adding R1R0 defines > + will set different resistance values. > + > + bias-pull-down: > + oneOf: > + - type: boolean > + - enum: [100, 101, 102, 103] > + description: Pull down PUPD/R0/R1 type define value. > + description: | > + For normal pull down type, it is not necessary to specify R1R0 > + values; When pull down type is PUPD/R0/R1, adding R1R0 defines > + will set different resistance values. > > input-enable: true > > @@ -151,7 +207,7 @@ patternProperties: > input-schmitt-disable: true > > drive-strength: > - enum: [2, 4, 8, 12, 16] > + enum: [2, 4, 6, 8, 10, 12, 14, 16] > > slew-rate: > enum: [0, 1] > @@ -218,8 +274,8 @@ examples: > #interrupt-cells = <2>; > interrupts = ; > > - mmc0_pins_default: mmc0-0 { > - cmd-dat-pins { > + mmc0_pins_default: mmc0-pins { > + pins-cmd-dat { > pinmux = , > , > , > @@ -232,11 +288,11 @@ examples: > input-enable; > mediatek,pull-up-adv = <1>; > }; > - clk-pins { > + pins-clk { > pinmux = ; > mediatek,pull-down-adv = <2>; > }; > - rst-pins { > + pins-rst { > pinmux = ; > mediatek,pull-up-adv = <0>; > };