From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@somainline.org>,
Andy Gross <agross@kernel.org>, Lee Jones <lee@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: soc: qcom: convert non-smd RPM bindings to dt-schema
Date: Thu, 6 Oct 2022 14:53:37 -0500 [thread overview]
Message-ID: <20221006195337.GA69592-robh@kernel.org> (raw)
In-Reply-To: <20221005-mdm9615-pinctrl-yaml-v1-4-0cbc006e2a30@linaro.org>
On Thu, Oct 06, 2022 at 09:58:01AM +0000, Neil Armstrong wrote:
> Convert the non-SMD RPM node bindings to dt-schema, the regulators subnode
> refers to regulators,yaml until we have the proper bindings.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom-rpm.txt | 39 +-----------
> .../devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml | 73 ++++++++++++++++++++++
> 2 files changed, 74 insertions(+), 38 deletions(-)
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml
> new file mode 100644
> index 000000000000..d416950189d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ipc-rpm.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ipc-rpm.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Resource Power Manager (RPM) over IPC
> +
> +description: |
> + This driver is used to interface with the Resource Power Manager (RPM) found
> + in various Qualcomm platforms. The RPM allows each component in the system
> + to vote for state of the system resources, such as clocks, regulators and bus
> + frequencies.
> +
> +maintainers:
> + - Bjorn Andersson <andersson@kernel.org>
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,rpm-apq8064
> + - qcom,rpm-msm8660
> + - qcom,rpm-msm8960
> + - qcom,rpm-ipq8064
> + - qcom,rpm-mdm9615
> +
> + reg: true
> +
> + interrupts:
> + minItems: 3
maxItems: 3
(Instead)
> +
> + interrupt-names:
> + items:
> + - const: ack
> + - const: err
> + - const: wakeup
> +
> + qcom,ipc:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to a syscon node representing the APCS registers
> + - description: u32 representing offset to the register within the syscon
> + - description: u32 representing the ipc bit within the register
> + description:
> + Three entries specifying the outgoing ipc bit used for signaling the RPM.
> +
> + regulators:
> + type: object
> + $ref: /schemas/regulator/regulator.yaml#
regulator.yaml applies to a single regulator, but 'regulators' sounds
like a container node with multiple regulators.
Would be good if the example showed...
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - qcom,ipc
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + rpm@108000 {
> + compatible = "qcom,rpm-msm8960";
> + reg = <0x108000 0x1000>;
> + qcom,ipc = <&apcs 0x8 2>;
> +
> + interrupts = <GIC_SPI 19 IRQ_TYPE_NONE>, <GIC_SPI 21 IRQ_TYPE_NONE>, <GIC_SPI 22 IRQ_TYPE_NONE>;
> + interrupt-names = "ack", "err", "wakeup";
> + };
>
> --
> b4 0.10.1
>
next prev parent reply other threads:[~2022-10-06 19:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 9:57 [PATCH 0/6] arm: qcom: mdm9615: second round of bindings and DT fixes Neil Armstrong
2022-10-06 9:57 ` [PATCH 1/6] dt-bindings: pinctrl: convert qcom,mdm9615-pinctrl.txt to dt-schema Neil Armstrong
2022-10-06 11:09 ` Krzysztof Kozlowski
2022-10-06 16:20 ` Neil Armstrong
2022-10-06 20:20 ` Krzysztof Kozlowski
2022-10-06 12:27 ` Rob Herring
2022-10-06 16:21 ` Neil Armstrong
2022-10-06 19:42 ` Rob Herring
2022-10-06 9:57 ` [PATCH 2/6] arm: dts: qcom: mdm9615: fix pinctrl subnodes Neil Armstrong
2022-10-06 11:10 ` Krzysztof Kozlowski
2022-10-07 19:36 ` Konrad Dybcio
2022-10-06 9:58 ` [PATCH 3/6] arm: dts: qcom: mdm9615: wp8548-mangoh-green: fix sx150xq node names and probe-reset property Neil Armstrong
2022-10-07 19:38 ` Konrad Dybcio
2022-10-10 7:45 ` Neil Armstrong
2022-10-06 9:58 ` [PATCH 4/6] dt-bindings: soc: qcom: convert non-smd RPM bindings to dt-schema Neil Armstrong
2022-10-06 19:53 ` Rob Herring [this message]
2022-10-06 9:58 ` [PATCH 5/6] dt-bindings: regulators: convert non-smd RPM Regulators " Neil Armstrong
2022-10-06 12:27 ` Rob Herring
2022-10-06 20:04 ` Rob Herring
2022-10-06 9:58 ` [PATCH 6/6] dt-bindings: soc: qcom: ipc-rpm: refer to qcom,ipc-rpm-regulator.yaml Neil Armstrong
2022-10-06 12:27 ` Rob Herring
2022-10-06 20:05 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006195337.GA69592-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).