From: Nishanth Menon <nm@ti.com>
To: Apurva Nandan <a-nandan@ti.com>
Cc: Andrew Davis <afd@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-gpio@vger.kernel.org>, Hari Nagalla <hnagalla@ti.com>
Subject: Re: [PATCH v2 4/4] arm64: dts: ti: Add support for J784S4 EVM board
Date: Mon, 14 Nov 2022 22:52:26 -0600 [thread overview]
Message-ID: <20221115045226.6l4j4qbvedv2whjq@effects> (raw)
In-Reply-To: <581d0735-8294-5805-9a44-ed4ec3e9ae54@ti.com>
On 17:48-20221111, Apurva Nandan wrote:
>
[...]
> > > Schematics: https://www.ti.com/lit/zip/sprr458
> > >
> > > Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> > > Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> > > Signed-off-by: Nishanth Menon <nm@ti.com>
> > > Signed-off-by: Matt Ranostay <mranostay@ti.com>
> > > Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> > > Signed-off-by: Suman Anna <s-anna@ti.com>
> > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> > > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Uggh - too many Signed-off-by -> Can we either trim this down or use
Co-developed-by ?
The last of the SoB should be yours as you are handing the patch over.
> > > ---
> > > arch/arm64/boot/dts/ti/Makefile | 2 +
> > > arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 199 +++++++++++++++++++++++
> > > 2 files changed, 201 insertions(+)
> > > create mode 100644 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> > > index 02e5d80344d0..6381c458738a 100644
> > > --- a/arch/arm64/boot/dts/ti/Makefile
> > > +++ b/arch/arm64/boot/dts/ti/Makefile
> > > @@ -19,6 +19,8 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-common-proc-board.dtb
> > > dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
One EoL here please? helps keeps the dtbs grouped.
> > > +dtb-$(CONFIG_ARCH_K3) += k3-j784s4-evm.dtb
> > > +
> > > dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb
> > > dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb
> > > diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > > new file mode 100644
> > > index 000000000000..bf2f2dfb7658
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> > > @@ -0,0 +1,199 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright (C) 2022 Texas Instruments Incorporated - https://www.ti.com/
> > > + *
> > > + * Common Processor Board: https://www.ti.com/tool/J721EXCPXEVM
> > This doesn't seem to be the right EVM, I'd just drop this link.
Please use the proper link -> I think it is in commit message.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2022-11-15 4:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 8:23 [PATCH v2 0/4] Add initial support for J784S4 SoC Apurva Nandan
2022-10-14 8:23 ` [PATCH v2 1/4] dt-bindings: arm: ti: Add bindings for J784s4 SoC Apurva Nandan
2022-10-14 8:23 ` [PATCH v2 2/4] dt-bindings: pinctrl: k3: Introduce pinmux definitions for J784s4 Apurva Nandan
2022-10-14 8:23 ` [PATCH v2 3/4] arm64: dts: ti: Add initial support for J784S4 SoC Apurva Nandan
2022-10-19 17:26 ` Andrew Davis
2022-10-14 8:23 ` [PATCH v2 4/4] arm64: dts: ti: Add support for J784S4 EVM board Apurva Nandan
2022-10-19 17:31 ` Andrew Davis
2022-11-11 12:18 ` Apurva Nandan
2022-11-15 4:52 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115045226.6l4j4qbvedv2whjq@effects \
--to=nm@ti.com \
--cc=a-nandan@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).