From: Esteban Blanc <eblanc@baylibre.com>
To: linus.walleij@linaro.org, lgirdwood@gmail.com,
broonie@kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-rtc@vger.kernel.org, jpanis@baylibre.com,
jneanne@baylibre.com, sterzik@ti.com, u-kumar1@ti.com
Subject: [PATCH v2 0/3] TI TPS6594 PMIC support (RTC, pinctrl, regulators, device trees)
Date: Tue, 28 Mar 2023 11:14:45 +0200 [thread overview]
Message-ID: <20230328091448.648452-1-eblanc@baylibre.com> (raw)
TPS6594 is a Power Management IC which provides regulators and others
features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
communicate through the I2C or SPI interfaces.
TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
This series adds support to TI TPS6594 PMIC and its derivatives.
This should be applied on top of other patch series:
- https://lore.kernel.org/all/20230216114410.183489-1-jpanis@baylibre.com/
For core MFD driver
The features implemented in this series are:
- RTC (child device)
- Pinmux/GPIO (child device)
- Regulator (child device)
RTC description:
The TPS6594 family has an RTC built-in, except for LP8764.
It provides time and an alarm.
Pinmux/GPIO:
TPS6594 family has 11 GPIOs. Those GPIO can also serve different
functions such as I2C or SPI interface, watchdog disable functions.
The driver provides both pinmuxing for the functions and GPIO capability.
Regulator:
TPS6594/TPS6593: 5 BUCKs and 4LDOs
LP8764: 4 BUCKs and no LDO
Bucks can be used in multipahse mode
Changes since v1:
Rtc:
- Removed struct tps6594_rtc
- Removed some dev_err messages
- Removed some comments
- Remove some whitespaces in comments and error messages
- Check if RTC is running before reading a timestamp in read_rtc
- Stop RTC at the end of probe to wait for a timestamp to be set
- Add default MFD_TPS6594 to Kconfig
Pinctrl:
- Removed #define DEBUG
- Add default MFD_TPS6594 to Kconfig
- Fix typo and reword help message of Kconfig
Regulators:
Further to Mark Brown review:
- File header whole block C++ style
- Configuring modes not supported: omit all mode operations
- Log the error before notifying
- Request the interrupts while registering the regulators (then remove
the lookup function)
Further to Matti review:
- Postponed: devm_regulator_irq_helper() and
regulator_irq_map_event_simple() can probably be used but code
refactoring is not so trivial. This can be done later as an enhancement
after this patch list is merged.
Buck Multi phase management:
- Multiphase property can take an array when 2 multi phase buck, buck12
and buck34
- Configuration multi phase buck34 without multiphase buck12 is not
supported (when only one multiphase, must be buck12). Not clear from the
spec but confirmed by TI.
- Supported multiphase conficurations: buck12, buck123, buck1234,
buck12 + buck34
- All interrupts are attached to the multiphase buck (ie: for regulator
buck12, buck1 & buck2 interrupts are registered)
Esteban Blanc (2):
rtc: tps6594: add driver for TPS6594 PMIC RTC
pinctrl: tps6594: add for TPS6594 PMIC
Jerome Neanne (1):
regulator: tps6594-regulator: Add driver for TI TPS6594 regulators
drivers/pinctrl/Kconfig | 10 +
drivers/pinctrl/Makefile | 1 +
drivers/pinctrl/pinctrl-tps6594.c | 365 +++++++++++++++
drivers/regulator/Kconfig | 13 +
drivers/regulator/Makefile | 1 +
drivers/regulator/tps6594-regulator.c | 628 ++++++++++++++++++++++++++
drivers/rtc/Kconfig | 9 +
drivers/rtc/Makefile | 1 +
drivers/rtc/rtc-tps6594.c | 462 +++++++++++++++++++
9 files changed, 1490 insertions(+)
create mode 100644 drivers/pinctrl/pinctrl-tps6594.c
create mode 100644 drivers/regulator/tps6594-regulator.c
create mode 100644 drivers/rtc/rtc-tps6594.c
--
2.39.2
next reply other threads:[~2023-03-28 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 9:14 Esteban Blanc [this message]
2023-03-28 9:14 ` [PATCH v2 1/3] rtc: tps6594: add driver for TPS6594 PMIC RTC Esteban Blanc
2023-03-28 9:29 ` Alexandre Belloni
2023-03-28 13:01 ` Esteban Blanc
2023-03-28 13:34 ` Alexandre Belloni
2023-03-28 13:59 ` Esteban Blanc
2023-03-28 9:14 ` [PATCH v2 2/3] pinctrl: tps6594: add for TPS6594 PMIC Esteban Blanc
2023-03-28 9:14 ` [PATCH v2 3/3] regulator: tps6594-regulator: Add driver for TI TPS6594 regulators Esteban Blanc
2023-03-28 20:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328091448.648452-1-eblanc@baylibre.com \
--to=eblanc@baylibre.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=jneanne@baylibre.com \
--cc=jpanis@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sterzik@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).