From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BB32C4332F for ; Fri, 16 Dec 2022 21:51:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229469AbiLPVva (ORCPT ); Fri, 16 Dec 2022 16:51:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbiLPVv3 (ORCPT ); Fri, 16 Dec 2022 16:51:29 -0500 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 816F55EDED for ; Fri, 16 Dec 2022 13:51:25 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D3BA184F72; Fri, 16 Dec 2022 22:51:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671227484; bh=TaufkRPCCj2JqxUzJ9D2saPzAqmTIvwTgeI/62dy3Ig=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pjL+RnWNfH9v1XdPxbtyzVWxDlzw78R+p2kLeKotuNvJUw4y9LFmK6IUOkpT1nmpC jjIgvA/jvIFfCgN5CoN2Sbnt7F6C6kRgmlgz2PpMAn++xNYgpQxjNOFD+aGMMLd8wC 7rMzz/tj7MYyFh6TbsCqDPCI+R5b52hh7SYaFoE/s9jdhYKIy0BghixhXiwu0p6imK rgelgt9LYq7TJ5xplAgPNQCjyvfcoTDS3kSzGJsX+PhRUclb8HRYeSFRsBknefWlIb nje/Boxe5Oowksy438O9MlkIW5sQO7i22Hv7FFvOyTQlSjSu9Ua6PII5VBLw1mFEhx twNx52Nh/JG2g== Message-ID: <24df1fa1-c24e-a07b-f7bc-dbf9f059549d@denx.de> Date: Fri, 16 Dec 2022 22:51:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v6 2/2] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode Content-Language: en-US To: Linus Walleij Cc: linux-gpio@vger.kernel.org, Bartosz Golaszewski , Loic Poulain , Marc Zyngier , NXP Linux Team , Peng Fan , Shawn Guo References: <20221013215946.216184-1-marex@denx.de> <20221013215946.216184-2-marex@denx.de> From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 10/17/22 12:24, Linus Walleij wrote: > On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut wrote: > >> Always configure GPIO pins which are used as interrupt source as INPUTs. >> In case the default pin configuration is OUTPUT, or the prior stage does >> configure the pins as OUTPUT, then Linux will not reconfigure the pin as >> INPUT and no interrupts are received. >> >> Always configure the interrupt source GPIO pin as input to fix the above case. >> >> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform") >> Signed-off-by: Marek Vasut > > Reviewed-by: Linus Walleij Can you please just pick these two patches up ? Thank you