From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6147C0650F for ; Sun, 11 Aug 2019 20:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B1062084D for ; Sun, 11 Aug 2019 20:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726011AbfHKUoh (ORCPT ); Sun, 11 Aug 2019 16:44:37 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:57393 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfHKUoh (ORCPT ); Sun, 11 Aug 2019 16:44:37 -0400 Received: from [192.168.1.162] ([37.4.249.106]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MzQwa-1iAAHw3YDw-00vOkk; Sun, 11 Aug 2019 22:43:44 +0200 Subject: Re: [PATCH 07/18] clk: bcm2835: Introduce SoC specific clock registration To: Stefan Wahren , Eric Anholt , Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Matthias Brugger , Rob Herring , Mark Rutland , Linus Walleij , Michael Turquette , Stephen Boyd , Ulf Hansson , Adrian Hunter Cc: linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <1563774880-8061-1-git-send-email-wahrenst@gmx.net> <1563774880-8061-8-git-send-email-wahrenst@gmx.net> From: Stefan Wahren Openpgp: preference=signencrypt Autocrypt: addr=stefan.wahren@i2se.com; keydata= xsFNBFt6gBMBEACub/pBevHxbvJefyZG32JINmn2bsEPX25V6fejmyYwmCGKjFtL/DoUMEVH DxCJ47BMXo344fHV1C3AnudgN1BehLoBtLHxmneCzgH3KcPtWW7ptj4GtJv9CQDZy27SKoEP xyaI8CF0ygRxJc72M9I9wmsPZ5bUHsLuYWMqQ7JcRmPs6D8gBkk+8/yngEyNExwxJpR1ylj5 bjxWDHyYQvuJ5LzZKuO9LB3lXVsc4bqXEjc6VFuZFCCk/syio/Yhse8N+Qsx7MQagz4wKUkQ QbfXg1VqkTnAivXs42VnIkmu5gzIw/0tRJv50FRhHhxpyKAI8B8nhN8Qvx7MVkPc5vDfd3uG YW47JPhVQBcUwJwNk/49F9eAvg2mtMPFnFORkWURvP+G6FJfm6+CvOv7YfP1uewAi4ln+JO1 g+gjVIWl/WJpy0nTipdfeH9dHkgSifQunYcucisMyoRbF955tCgkEY9EMEdY1t8iGDiCgX6s 50LHbi3k453uacpxfQXSaAwPksl8MkCOsv2eEr4INCHYQDyZiclBuuCg8ENbR6AGVtZSPcQb enzSzKRZoO9CaqID+favLiB/dhzmHA+9bgIhmXfvXRLDZze8po1dyt3E1shXiddZPA8NuJVz EIt2lmI6V8pZDpn221rfKjivRQiaos54TgZjjMYI7nnJ7e6xzwARAQABzSlTdGVmYW4gV2Fo cmVuIDxzdGVmYW4ud2FocmVuQGluLXRlY2guY29tPsLBdwQTAQgAIQUCXIdehwIbAwULCQgH AgYVCAkKCwIEFgIDAQIeAQIXgAAKCRCUgewPEZDy2yHTD/9UF7QlDkGxzQ7AaCI6N95iQf8/ 1oSUaDNu2Y6IK+DzQpb1TbTOr3VJwwY8a3OWz5NLSOLMWeVxt+osMmlQIGubD3ODZJ8izPlG /JrNt5zSdmN5IA5f3esWWQVKvghZAgTDqdpv+ZHW2EmxnAJ1uLFXXeQd3UZcC5r3/g/vSaMo 9xek3J5mNuDm71lEWsAs/BAcFc+ynLhxwBWBWwsvwR8bHtJ5DOMWvaKuDskpIGFUe/Kb2B+j ravQ3Tn6s/HqJM0cexSHz5pe+0sGvP+t9J7234BFQweFExriey8UIxOr4XAbaabSryYnU/zV H9U1i2AIQZMWJAevCvVgQ/U+NeRhXude9YUmDMDo2sB2VAFEAqiF2QUHPA2m8a7EO3yfL4rM k0iHzLIKvh6/rH8QCY8i3XxTNL9iCLzBWu/NOnCAbS+zlvLZaiSMh5EfuxTtv4PlVdEjf62P +ZHID16gUDwEmazLAMrx666jH5kuUCTVymbL0TvB+6L6ARl8ANyM4ADmkWkpyM22kCuISYAE fQR3uWXZ9YgxaPMqbV+wBrhJg4HaN6C6xTqGv3r4B2aqb77/CVoRJ1Z9cpHCwiOzIaAmvyzP U6MxCDXZ8FgYlT4v23G5imJP2zgX5s+F6ACUJ9UQPD0uTf+J9Da2r+skh/sWOnZ+ycoHNBQv ocZENAHQf87BTQRbeoATARAA2Hd0fsDVK72RLSDHby0OhgDcDlVBM2M+hYYpO3fX1r++shiq PKCHVAsQ5bxe7HmJimHa4KKYs2kv/mlt/CauCJ//pmcycBM7GvwnKzmuXzuAGmVTZC6WR5Lk akFrtHOzVmsEGpNv5Rc9l6HYFpLkbSkVi5SPQZJy+EMgMCFgjrZfVF6yotwE1af7HNtMhNPa LDN1oUKF5j+RyRg5iwJuCDknHjwBQV4pgw2/5vS8A7ZQv2MbW/TLEypKXif78IhgAzXtE2Xr M1n/o6ZH71oRFFKOz42lFdzdrSX0YsqXgHCX5gItLfqzj1psMa9o1eiNTEm1dVQrTqnys0l1 8oalRNswYlQmnYBwpwCkaTHLMHwKfGBbo5dLPEshtVowI6nsgqLTyQHmqHYqUZYIpigmmC3S wBWY1V6ffUEmkqpAACEnL4/gUgn7yQ/5d0seqnAq2pSBHMUUoCcTzEQUWVkiDv3Rk7hTFmhT sMq78xv2XRsXMR6yQhSTPFZCYDUExElEsSo9FWHWr6zHyYcc8qDLFvG9FPhmQuT2s9Blx6gI 323GnEq1lwWPJVzP4jQkJKIAXwFpv+W8CWLqzDWOvdlrDaTaVMscFTeH5W6Uprl65jqFQGMp cRGCs8GCUW13H0IyOtQtwWXA4ny+SL81pviAmaSXU8laKaRu91VOVaF9f4sAEQEAAcLBXwQY AQIACQUCW3qAEwIbDAAKCRCUgewPEZDy2+oXD/9cHHRkBZOfkmSq14Svx062PtU0KV470TSn p/jWoYJnKIw3G0mXIRgrtH2dPwpIgVjsYyRSVMKmSpt5ZrDf9NtTbNWgk8VoLeZzYEo+J3oP qFrTMs3aYYv7e4+JK695YnmQ+mOD9nia915tr5AZj95UfSTlyUmyic1d8ovsf1fP7XCUVRFc RjfNfDF1oL/pDgMP5GZ2OwaTejmyCuHjM8IR1CiavBpYDmBnTYk7Pthy6atWvYl0fy/CqajT Ksx7+p9xziu8ZfVX+iKBCc+He+EDEdGIDhvNZ/IQHfOB2PUXWGS+s9FNTxr/A6nLGXnA9Y6w 93iPdYIwxS7KXLoKJee10DjlzsYsRflFOW0ZOiSihICXiQV1uqM6tzFG9gtRcius5UAthWaO 1OwUSCQmfCOm4fvMIJIA9rxtoS6OqRQciF3crmo0rJCtN2awZfgi8XEif7d6hjv0EKM9XZoi AZYZD+/iLm5TaKWN6oGIti0VjJv8ZZOZOfCb6vqFIkJW+aOu4orTLFMz28aoU3QyWpNC8FFm dYsVua8s6gN1NIa6y3qa/ZB8bA/iky59AEz4iDIRrgUzMEg8Ak7Tfm1KiYeiTtBDCo25BvXj bqsyxkQD1nkRm6FAVzEuOPIe8JuqW2xD9ixGYvjU5hkRgJp3gP5b+cnG3LPqquQ2E6goKUML AQ== Message-ID: <25c31fa6-6190-2742-07ab-4b34c3e08947@i2se.com> Date: Sun, 11 Aug 2019 22:43:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1563774880-8061-8-git-send-email-wahrenst@gmx.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Provags-ID: V03:K1:2TDJV0pnWxTMmEw/5R2DuGLJse/EyfjRUa75D6a2EIAubLjCj8e y9C6qZ4NU5SJxkTPPV9pSiT9jvBHhbdbcmXTwtqmS4boOV/S3bqjqYttSmRWm+zqHDXaSY2 VAdWwXkT4BYt+0xBcjbHv/TAcmtFn9HVAJZdygX8tqbKAs7jB4O6IoLUecuLq5b0+HeVhrH n0bptZ47g/ADqOtwZQphA== X-UI-Out-Filterresults: notjunk:1;V03:K0:fqYs4fAxwEg=:zEOKBmVNLKaxWqvxga+DW1 P4XlZ0Ms4fKu/fAiItFSO0xXagaME+2btpIufZtTlsBnyJ0JXEWiJR+nGgQmgRg9Vqu+kyzLn VmUyxK/632F2VT+f9OGIRjN2VsGpdF56WsIQUdAGxzz33ShcLBQmgPrC9nmu1dmYbYND4mRR6 oL/aUR4vhmp3zUOAnywqZtxxxIvqCjOIfRSHr/NyepKo0H8hXIBWnfMCRSv37XGl7pt9fk4Dk 8KY6S/NSnbXxPIdnuYqcI/WcX8ICkg1f0FxWiZ0Z7+sFjyazK+L+bZQ3TZMUQxIja8IaJxdV0 AlVSxzMiaQ5T3OAdVDcIvSuEayvJAB7ps7QeYQhd1CrnXT54lf+l7IRJkT+RucJsW8QsnZaYg yiL/Q4q36TFpwNDq0ZGW0fvlw7G1XBiVbO7ZqBQkGJFmfPkoOitLGu+RCbNc7mKWCAT3D6dCU 8e0pq1A5zNBzRA/cg5aFNjAfNWm9/Q6mwnSAlU8Vp0j8dfQ5tIXQIP2ZhWZ9nhShWQpOGhEYd hOLkv3p4xPoRZ2m6vXZvvUengCXGKvVDOhYjo78CsZ3d4RrxIGw+yuyFfmJJVFh8+nv5oXpUJ ITpztiRGh9FijcOReDtbpQauniMmA9TT+ExhbY81VdN/4OrykZ6b31xa559MPtD5E/FGIF9LX R51X3CoNs54yqrDr2rd4dctvP78on59VmhVZAiQk4MIbLfyAJxNML/uW82oLgwt4fUGL4sIEm tRdqIiHEoFMmOyky72PqD3ZuStqZw3zj+dvGLQOds/qHKwXJB71YFZTXMmA= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, Am 22.07.19 um 07:54 schrieb Stefan Wahren: > In order to support SoC specific clocks (e.g. emmc2 for BCM2711), we > extend the description with a SoC support flag. This approach avoids long > and mostly redundant lists of clock IDs. > > Suggested-by: Florian Fainelli > Signed-off-by: Stefan Wahren > --- > drivers/clk/bcm/clk-bcm2835.c | 103 +++++++++++++++++++++++++++++++++++------- > 1 file changed, 86 insertions(+), 17 deletions(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 867ae3c..3231b76 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -31,7 +31,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > @@ -289,6 +289,9 @@ > #define LOCK_TIMEOUT_NS 100000000 > #define BCM2835_MAX_FB_RATE 1750000000u > > +#define SOC_BCM2835 BIT(0) > +#define SOC_ALL (SOC_BCM2835) > + ... > .cm_reg = CM_PLLD, > @@ -1775,6 +1805,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > * It is in the HDMI power domain. > */ > [BCM2835_PLLH] = REGISTER_PLL( > + SOC_ALL, > "pllh", > .cm_ctrl_reg = CM_PLLH, > .a2w_ctrl_reg = A2W_PLLH_CTRL, > @@ -1789,6 +1820,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > .max_rate = 3000000000u, > .max_fb_rate = BCM2835_MAX_FB_RATE), > [BCM2835_PLLH_RCAL] = REGISTER_PLL_DIV( > + SOC_ALL, > .name = "pllh_rcal", > .source_pll = "pllh", > .cm_reg = CM_PLLH, > @@ -1798,6 +1830,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > .fixed_divider = 10, > .flags = CLK_SET_RATE_PARENT), > [BCM2835_PLLH_AUX] = REGISTER_PLL_DIV( > + SOC_ALL, > .name = "pllh_aux", > .source_pll = "pllh", > .cm_reg = CM_PLLH, > @@ -1807,6 +1840,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { > .fixed_divider = 1, > .flags = CLK_SET_RATE_PARENT), > [BCM2835_PLLH_PIX] = REGISTER_PLL_DIV( > + SOC_ALL, > .name = "pllh_pix", > .source_pll = "pllh", > .cm_reg = CM_PLLH, i was informed that at least all PLLH related clocks are BCM2835 specific. So please don't apply this patch. I will send a fixed version soon.