From: Michal Simek <michal.simek@xilinx.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Syed Nayyar Waris <syednwaris@gmail.com>,
Srinivas Neeli <srinivas.neeli@xilinx.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
"Arnd Bergmann" <arnd@arndb.de>,
Robert Richter <rrichter@marvell.com>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"(Exiting) Amit Kucheria" <amit.kucheria@verdurent.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value
Date: Tue, 5 Jan 2021 12:04:03 +0100 [thread overview]
Message-ID: <361b118a-f425-2b79-4220-47e3f9c39306@xilinx.com> (raw)
In-Reply-To: <CACRpkdYmoEjTzWv7wdrHhc8VFxFB+=QQwKA6YY+prydjgUB2aw@mail.gmail.com>
Hi, +Srinivas,
On 27. 12. 20 22:29, Linus Walleij wrote:
> On Sat, Dec 26, 2020 at 7:44 AM Syed Nayyar Waris <syednwaris@gmail.com> wrote:
>
>> This patch reimplements the xgpio_set_multiple() function in
>> drivers/gpio/gpio-xilinx.c to use the new generic functions:
>> bitmap_get_value() and bitmap_set_value(). The code is now simpler
>> to read and understand. Moreover, instead of looping for each bit
>> in xgpio_set_multiple() function, now we can check each channel at
>> a time and save cycles.
>>
>> Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
>> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
>
> (...)
>
>> +#include <../drivers/gpio/clump_bits.h>
>
> What is this?
>
> Isn't a simple
>
> #include "clump_bits.h"
>
> enough?
>
> We need an ACK from the Xilinx people that they think this
> actually improves the readability and maintainability of their
> driver.
Srinivas is going to send some patches against this driver. That's why
please take a look if both of these changes are fitting together.
Thanks,
Michal
next prev parent reply other threads:[~2021-01-05 11:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 6:41 [PATCH 0/5] Introduce the for_each_set_clump macro Syed Nayyar Waris
2020-12-26 6:42 ` [PATCH 1/5] clump_bits: " Syed Nayyar Waris
2020-12-27 22:03 ` Arnd Bergmann
2020-12-28 12:10 ` William Breathitt Gray
2020-12-26 6:43 ` [PATCH 2/5] lib/test_bitmap.c: Add for_each_set_clump test cases Syed Nayyar Waris
[not found] ` <CAHp75VcSsfDKY3w4ufZktXzRB=GiObAV6voPfmeAHcbdwX0uqg@mail.gmail.com>
2021-02-04 8:55 ` Syed Nayyar Waris
2021-02-07 4:18 ` Syed Nayyar Waris
2020-12-26 6:43 ` [PATCH 3/5] gpio: thunderx: Utilize for_each_set_clump macro Syed Nayyar Waris
2020-12-26 6:44 ` [PATCH 4/5] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Syed Nayyar Waris
2020-12-27 21:29 ` Linus Walleij
2021-01-05 11:04 ` Michal Simek [this message]
2020-12-26 6:45 ` [PATCH 5/5] gpio: xilinx: Add extra check if sum of widths exceed 64 Syed Nayyar Waris
2020-12-28 11:58 ` William Breathitt Gray
2021-01-05 11:01 ` Michal Simek
2020-12-27 21:26 ` [PATCH 0/5] Introduce the for_each_set_clump macro Linus Walleij
2021-01-05 14:19 ` Bartosz Golaszewski
2021-01-05 14:39 ` Andy Shevchenko
2021-01-06 7:27 ` Bartosz Golaszewski
2021-01-06 8:19 ` William Breathitt Gray
2021-01-05 11:09 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=361b118a-f425-2b79-4220-47e3f9c39306@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rrichter@marvell.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.neeli@xilinx.com \
--cc=syednwaris@gmail.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).