From: "Claus H. Stovgaard" <cst@phaseone.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH] gpio: don't WARN() on NULL descs if gpiolib is disabled
Date: Wed, 10 Jul 2019 20:02:22 +0000 [thread overview]
Message-ID: <41aedb602385b66772c4d2003f9be1df6f93a528.camel@phaseone.com> (raw)
In-Reply-To: <CACRpkdb5xKHZja0mkd-wZJ+YHZpGJaDrkA0dv60MNYKXFcPK4w@mail.gmail.com>
Hi Linus
On tir, 2019-07-09 at 15:30 +0200, Linus Walleij wrote:
>
> I remember I had this discussion in the past, and I made a large
> refactoring to make it possible for drivers that need gpiod_*
> calls to simply do:
>
> select GPIOLIB
>
> in Kconfig.
>
> This should solve also this problem I think.
>
> However I do realize that there may be situations where people
> simply want to make GPIO support entirely optional without
> having to e.g. create custom stubs and encapsulate things
> inside if IS_ENABLED(CONFIG_GPIOLIB).
You properly saw the email in linux-i2c, but will just it for
completeness.
https://marc.info/?l=linux-i2c&m=156257442124566&w=2
The background for getting the warning, was upgrading a system on
Xilinx ZynqMP SoC from 4.14 to 4.19. As part of this upgrade wp (write
protect) has been introduced in the at24 driver, resulting in the
warning from comsumer.h as I don't have enabled GPIOLIB.
Regards
Claus
prev parent reply other threads:[~2019-07-10 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 8:23 [PATCH] gpio: don't WARN() on NULL descs if gpiolib is disabled Bartosz Golaszewski
2019-07-08 10:18 ` Claus H. Stovgaard
2019-07-09 13:30 ` Linus Walleij
2019-07-09 14:20 ` Bartosz Golaszewski
2019-07-16 21:46 ` Linus Walleij
2019-07-20 18:03 ` Bartosz Golaszewski
2019-07-20 19:44 ` Linus Walleij
2019-07-22 6:14 ` Bartosz Golaszewski
2019-07-10 13:09 ` Enrico Weigelt, metux IT consult
2019-07-10 20:02 ` Claus H. Stovgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41aedb602385b66772c4d2003f9be1df6f93a528.camel@phaseone.com \
--to=cst@phaseone.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).