From: Michael Walle <michael@walle.cc>
To: linus.walleij@linaro.org
Cc: bgolaszewski@baylibre.com, devicetree@vger.kernel.org,
hui.song_1@nxp.com, leoyang.li@nxp.com,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
robh+dt@kernel.org, shawnguo@kernel.org
Subject: Re: [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs.
Date: Fri, 22 Nov 2019 14:08:08 +0100 [thread overview]
Message-ID: <563f2fdf0c32103d95a53fc1e7fd84c0@walle.cc> (raw)
In-Reply-To: <CACRpkdYhLoGdGQt_jzj5aFa-EY_kMimoVShi7QFLG3sZbC436w@mail.gmail.com>
>> From: Song Hui <hui.song_1@nxp.com>
>>
>> On these boards, the irq_set_type must point one valid function
>> pointer
>> that can correctly set both edge and falling edge.
>>
>> Signed-off-by: Song Hui <hui.song_1@nxp.com>
>
> Patch applied!
>
> Yours,
> Linus Walleij
mhh.. this bug should already be fixed in a better way with [1]:
gpio: mpc8xxx: Don't overwrite default irq_set_type callback
-michael
[1]
https://lore.kernel.org/lkml/CACRpkdZ5eWHEV-oN77QxH9X4DZRUB3zM=gP=+rM=ZLAX6Wxw9w@mail.gmail.com/
next prev parent reply other threads:[~2019-11-22 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 6:18 [PATCH v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs Hui Song
2019-11-22 13:01 ` Linus Walleij
2019-11-22 13:08 ` Michael Walle [this message]
2019-11-22 13:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563f2fdf0c32103d95a53fc1e7fd84c0@walle.cc \
--to=michael@walle.cc \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hui.song_1@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).