From: Stephen Boyd <swboyd@chromium.org>
To: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] gpio: Pass mask and size with the init_valid_mask()
Date: Mon, 19 Aug 2019 07:01:20 -0700 [thread overview]
Message-ID: <5d5aabb1.1c69fb81.869b6.c526@mx.google.com> (raw)
In-Reply-To: <20190819084904.30027-1-linus.walleij@linaro.org>
Quoting Linus Walleij (2019-08-19 01:49:04)
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 7f35c196bb3e..a5d8f75da4a7 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -593,24 +593,25 @@ static void msm_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> #define msm_gpio_dbg_show NULL
> #endif
>
> -static int msm_gpio_init_valid_mask(struct gpio_chip *chip)
> +static int msm_gpio_init_valid_mask(struct gpio_chip *gc,
Please leave the name as 'chip' like the other ops in this file. The
other uses of 'gc' in gpiolib are fine though.
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
prev parent reply other threads:[~2019-08-19 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:49 [PATCH] gpio: Pass mask and size with the init_valid_mask() Linus Walleij
2019-08-19 14:01 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5aabb1.1c69fb81.869b6.c526@mx.google.com \
--to=swboyd@chromium.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).