Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] pinctrl: bcm-iproc: Use SPDX header
@ 2019-08-12 13:04 Linus Walleij
  2019-08-12 15:59 ` Scott Branden
  0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2019-08-12 13:04 UTC (permalink / raw)
  To: linux-gpio; +Cc: Linus Walleij, Pramod Kumar, Ray Jui, Scott Branden

This convert the BCM IPROC driver to use the SPDX header
for indicating GPL v2.0 only licensing.

Cc: Pramod Kumar <pramodku@broadcom.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index b70058caee50..18ff01727e0e 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -1,17 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright (C) 2014-2017 Broadcom
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation version 2.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether express or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-/*
  * This file contains the Broadcom Iproc GPIO driver that supports 3
  * GPIO controllers on Iproc including the ASIU GPIO controller, the
  * chipCommonG GPIO controller, and the always-on GPIO controller. Basic
-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: bcm-iproc: Use SPDX header
  2019-08-12 13:04 [PATCH] pinctrl: bcm-iproc: Use SPDX header Linus Walleij
@ 2019-08-12 15:59 ` Scott Branden
  2019-08-15  7:51   ` Linus Walleij
  0 siblings, 1 reply; 4+ messages in thread
From: Scott Branden @ 2019-08-12 15:59 UTC (permalink / raw)
  To: Linus Walleij, linux-gpio; +Cc: Pramod Kumar, Ray Jui, Scott Branden

Hi Linus,

On 2019-08-12 6:04 a.m., Linus Walleij wrote:
> This convert the BCM IPROC driver to use the SPDX header
> for indicating GPL v2.0 only licensing.
>
> Cc: Pramod Kumar <pramodku@broadcom.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>   drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index b70058caee50..18ff01727e0e 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -1,17 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Copyright (C) 2014-2017 Broadcom
>    *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation version 2.
> - *
> - * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> - * kind, whether express or implied; without even the implied warranty
> - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - */
> -
> -/*

Please leave the file description comment separate from the license 
header/copyright notices.

ie. leave the above 3 lines intact.

>    * This file contains the Broadcom Iproc GPIO driver that supports 3
>    * GPIO controllers on Iproc including the ASIU GPIO controller, the
>    * chipCommonG GPIO controller, and the always-on GPIO controller. Basic

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: bcm-iproc: Use SPDX header
  2019-08-12 15:59 ` Scott Branden
@ 2019-08-15  7:51   ` Linus Walleij
  2019-08-15 16:58     ` Scott Branden
  0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2019-08-15  7:51 UTC (permalink / raw)
  To: Scott Branden
  Cc: open list:GPIO SUBSYSTEM, Pramod Kumar, Ray Jui, Scott Branden

On Mon, Aug 12, 2019 at 5:59 PM Scott Branden
<scott.branden@broadcom.com> wrote:

> Please leave the file description comment separate from the license
> header/copyright notices.
>
> ie. leave the above 3 lines intact.

OK... Why?

Is this because you have an automated tool that likes this format:

/*
 * Copyright ...
 */

/*
 * Other stuff
 */

Or is it just a personal (perception) preference?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pinctrl: bcm-iproc: Use SPDX header
  2019-08-15  7:51   ` Linus Walleij
@ 2019-08-15 16:58     ` Scott Branden
  0 siblings, 0 replies; 4+ messages in thread
From: Scott Branden @ 2019-08-15 16:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: open list:GPIO SUBSYSTEM, Pramod Kumar, Ray Jui, Scott Branden


On 2019-08-15 12:51 a.m., Linus Walleij wrote:
> On Mon, Aug 12, 2019 at 5:59 PM Scott Branden
> <scott.branden@broadcom.com> wrote:
>
>> Please leave the file description comment separate from the license
>> header/copyright notices.
>>
>> ie. leave the above 3 lines intact.
> OK... Why?
For consistency following the internal template we follow.
>
> Is this because you have an automated tool that likes this format:
>
> /*
>   * Copyright ...
>   */
>
> /*
>   * Other stuff
>   */
>
> Or is it just a personal (perception) preference?
Yes, we do have an automated tool which performs such scans.  And then 
we need to go in and adjust the licenses back to the format you've 
described.
>
> Yours,
> Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 13:04 [PATCH] pinctrl: bcm-iproc: Use SPDX header Linus Walleij
2019-08-12 15:59 ` Scott Branden
2019-08-15  7:51   ` Linus Walleij
2019-08-15 16:58     ` Scott Branden

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org linux-gpio@archiver.kernel.org
	public-inbox-index linux-gpio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox