From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F277C4332F for ; Wed, 19 Oct 2022 15:59:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbiJSP73 (ORCPT ); Wed, 19 Oct 2022 11:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231589AbiJSP6u (ORCPT ); Wed, 19 Oct 2022 11:58:50 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 581B81BE932 for ; Wed, 19 Oct 2022 08:57:47 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id o2so10959972qkk.10 for ; Wed, 19 Oct 2022 08:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XuH1cwGYuoIXuHDHrxmGsjJyFHpkABDYVCIkLmAK2bw=; b=ghdwkgoTZX+EiHmt/h6EJyEpxc3hSgg79jAPidHTEO5U7Oacb2f7aV9dA16+K2MI+2 ZzRKn6SblRwL+Rux3tzWlTKKK0E+pXdghGvOqIUCGWlsFEqRDdMrL3lJvy/xM9Jm/J8i RRa9s8ygIFflpnEI7Oafv9LZ+seAPhNZ0bpscvw5Yk0pUNTAgLlOCdBvKHWaC+TKSBEN /xlpUA+2rL7MD4soWBynVfAodBYwZDxgDAvIr/lbs3fW72ukn33S338xKxaC+S1OptCh hBSPFsIFUsKwTeGOzyu+tPtH7BasQmSIyETOFf+XPtp2krHM8NbAy1mN78PRPba3v0gl yIow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XuH1cwGYuoIXuHDHrxmGsjJyFHpkABDYVCIkLmAK2bw=; b=Ffs8bPdwz1+NbrDj73FkFXrTT8CO+Q/NMMxxjnsbbh9P7vONVowDnnQn/DKGdLAXqQ dB8+amF/1iuaWCmtV5BewVHvxPyrxaR6hq7tbm35Viqo0S3xv5zIhSaKMG7V34dbrkiI JOyptF+iXAUBve+23Z995YdTKO4TMnmvL16Clo1bF9ACVw8wrEHsKeL94gRz2OmoMhNr 7qbmyPR/EmI5WQiA/F46V4O54OM2qAIW+dBQIAJRpy0Ovk37tRGyluC5DGeC5A3v1Y7c RGpaIv1vPlnz9TJ1D+vf9OcAEqBFWUjZ0bh+u1kzh/gY5s2cSEnVzipF2VOHy8RJjwtD wnWw== X-Gm-Message-State: ACrzQf3DpjGMo+EyKE4soEV1BygQNeYFAQ0h63GuyroU0aegHBgyBZCs 2jCdAGXaCb4jKtjj5BOat1+nCNOC61VQNg== X-Google-Smtp-Source: AMsMyM4eCXdcxPYYjqQ4LMC6OlOLsmYWjCS81HiLMFGL1eq8MVPxt363n9uh3cA7kLDZL6Qos11S6g== X-Received: by 2002:a05:620a:30b:b0:6e4:6de2:7f38 with SMTP id s11-20020a05620a030b00b006e46de27f38mr6179989qkm.520.1666195060953; Wed, 19 Oct 2022 08:57:40 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id i23-20020ac84897000000b0039853b7b771sm4218488qtq.80.2022.10.19.08.57.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 08:57:40 -0700 (PDT) Message-ID: <6b71bc77-b168-282b-9318-1640bba4e946@linaro.org> Date: Wed, 19 Oct 2022 11:57:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 4/4] dt-bindings: pinctrl: qcom,sc7180: convert to dtschema Content-Language: en-US To: Doug Anderson Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Kaehlcke , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring References: <20221019001351.1630089-1-krzysztof.kozlowski@linaro.org> <20221019001351.1630089-5-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 19/10/2022 11:48, Doug Anderson wrote: > Hi, > > On Tue, Oct 18, 2022 at 5:14 PM Krzysztof Kozlowski > wrote: >> >> Convert Qualcomm SC7180 pin controller bindings to DT schema. Keep the >> parsing of pin configuration subnodes consistent with other Qualcomm >> schemas (children named with '-state' suffix, their children with >> '-pins'). >> >> Signed-off-by: Krzysztof Kozlowski >> Reviewed-by: Rob Herring >> >> --- >> >> Changes since v2: >> 1. Drop entire drive-strength (not needed, brought by common TLMM >> schema). >> >> Changes since v1: >> 1. Drop default:2 for drive strength >> 2. Add Rb tag. >> >> Cc: Doug Anderson >> --- >> .../bindings/pinctrl/qcom,sc7180-pinctrl.txt | 187 ------------------ >> .../bindings/pinctrl/qcom,sc7180-pinctrl.yaml | 158 +++++++++++++++ >> 2 files changed, 158 insertions(+), 187 deletions(-) > > Looks great now. > > Reviewed-by: Douglas Anderson Thanks > > Will you also send out separate patches to fix up the "drive strength" > for all the other Qualcomm boards. They all have the same problem. The > drive strength never defaults to 2 and always gets left at whatever > the BIOS leaves it at unless it's specified. If you mean - other bindings for Qualcomm - then answer is yes. Several things are already applied and will pop-up in tomorrow's next: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-dt.git/log/?h=next/qcom-pinctrl I'll go in spare time with rest of bindings. Best regards, Krzysztof