From: Michal Simek <michal.simek@amd.com>
To: Rob Herring <robh@kernel.org>,
Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<saikrishna12468@gmail.com>, <git@amd.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration"
Date: Fri, 21 Oct 2022 09:21:54 +0200 [thread overview]
Message-ID: <7383e705-6b8a-9e3e-ee94-6c59d8173779@amd.com> (raw)
In-Reply-To: <20221021011125.GA2104528-robh@kernel.org>
Hi Rob,
On 10/21/22 03:11, Rob Herring wrote:
> On Mon, Oct 17, 2022 at 06:33:03PM +0530, Sai Krishna Potthuri wrote:
>> This reverts commit 133ad0d9af99bdca90705dadd8d31c20bfc9919f.
>>
>> On systems with older PMUFW (Xilinx ZynqMP Platform Management Firmware)
>> using these pinctrl properties can cause system hang because there is
>> missing feature autodetection.
>> When this feature is implemented, support for these two properties should
>> bring back.
>
> So I'm going to get to review the revert of the revert at some point?
> Why do the properties need to be removed from the binding? They work on
> 'not older' firmware, right? Isn't just removing the driver support or
> removing from .dts files enough?
Removing functionality should be IMHO enough. Maybe make sense to inform users
that there is missing functionality where they define these properties via DT.
Thanks,
Michal
next prev parent reply other threads:[~2022-10-21 7:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 13:03 [PATCH v2 0/2] pinctrl: pinctrl-zynqmp: Revert output-enable and bias-high-impedance support Sai Krishna Potthuri
2022-10-17 13:03 ` [PATCH v2 1/2] Revert "pinctrl: pinctrl-zynqmp: Add support for output-enable and bias-high-impedance" Sai Krishna Potthuri
2022-10-17 13:03 ` [PATCH v2 2/2] Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration" Sai Krishna Potthuri
2022-10-21 1:11 ` Rob Herring
2022-10-21 7:21 ` Michal Simek [this message]
2022-10-17 13:13 ` [PATCH v2 0/2] pinctrl: pinctrl-zynqmp: Revert output-enable and bias-high-impedance support Michal Simek
2022-10-18 7:51 ` Linus Walleij
2022-10-18 8:06 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7383e705-6b8a-9e3e-ee94-6c59d8173779@amd.com \
--to=michal.simek@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=saikrishna12468@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).