From: Sungbo Eo <mans0n@gorani.run>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] gpio: add GPO driver for PCA9570
Date: Thu, 25 Jun 2020 16:34:52 +0900 [thread overview]
Message-ID: <7965f173-2668-b122-1ba8-9fbf7d169e33@gorani.run> (raw)
In-Reply-To: <CAHp75VfMQh3KW276uAwBV-nOVTnLaAspGijPHyZjuHzm4XLPag@mail.gmail.com>
On 2020-06-24 22:01, Andy Shevchenko wrote:
> On Tue, Jun 23, 2020 at 9:06 AM Sungbo Eo <mans0n@gorani.run> wrote:
>>
>> This patch adds support for the PCA9570 I2C GPO expander.
>
>> Tested in kernel 5.4 on an ipq40xx platform.
>>
>> This is my first time submitting a whole driver patch, and I'm not really familiar with this PCA expander series.
>> Please let me know how I can improve this patch further. (Do I also need to document the DT compatible string?)
>>
>> FYI there's an unmerged patch for this chip.
>> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2017-May/105602.html
>> I don't have PCA9571 either so I didn't add support for it.
>
> My very first questions to such (simple) driver submissions is: Have
> you conducted research of existing drivers and found that none is
> suitable for this chip?
> Do this and answer in a commit message, if it will be still valid.
>
I've done a more extensive research for i2c expanders and found out that
gw-pld, max732x, pcf857x also use i2c_smbus_write_byte() without reg
address. But their architectures are more complex than pca9570 and I'm
not sure if I can make them compatible with pca9570. (I still don't
understand what "quasi-bidirectional" in pcf857x means...)
prev parent reply other threads:[~2020-06-25 7:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 6:05 [PATCH] gpio: add GPO driver for PCA9570 Sungbo Eo
2020-06-23 8:31 ` Michael Walle
2020-06-23 12:22 ` Sungbo Eo
2020-06-23 12:47 ` Michael Walle
2020-06-24 13:33 ` Andy Shevchenko
2020-06-24 13:46 ` Michael Walle
2020-06-24 14:52 ` Andy Shevchenko
2020-06-27 16:58 ` Michael Walle
2020-06-24 12:29 ` Bartosz Golaszewski
2020-06-24 13:01 ` Andy Shevchenko
2020-06-25 7:34 ` Sungbo Eo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7965f173-2668-b122-1ba8-9fbf7d169e33@gorani.run \
--to=mans0n@gorani.run \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).