From: "Arnd Bergmann" <arnd@arndb.de>
To: "Robert Jarzmik" <jarzmik.robert@orange.fr>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
"Daniel Mack" <daniel@zonque.org>,
"Haojian Zhuang" <haojian.zhuang@gmail.com>,
linux-kernel@vger.kernel.org,
"Alan Stern" <stern@rowland.harvard.edu>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Dominik Brodowski" <linux@dominikbrodowski.net>,
"Felipe Balbi" <balbi@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Helge Deller" <deller@gmx.de>,
perex@perex.cz, jingoohan1@gmail.com,
"Lee Jones" <lee@kernel.org>,
kernel@wantstofly.org, lgirdwood@gmail.com,
"Linus Walleij" <linus.walleij@linaro.org>,
marek.vasut@gmail.com, "Mark Brown" <broonie@kernel.org>,
mkpetch@internode.on.net,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
lost.distance@yahoo.com, philipp.zabel@gmail.com,
"Russell King" <linux@armlinux.org.uk>,
sre@kernel.org, slapin@ossfans.org,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
tiwai@suse.com, "Ulf Hansson" <ulf.hansson@linaro.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-pm@vger.kernel.org, linux-ide@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-input@vger.kernel.org, patches@opensource.cirrus.com,
linux-leds@vger.kernel.org,
"linux-mmc @ vger . kernel . org" <linux-mmc@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 00/30] ARM: pxa: remove all unused boards&drivers
Date: Thu, 20 Oct 2022 09:30:03 +0200 [thread overview]
Message-ID: <7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com> (raw)
In-Reply-To: <m2r0z3h5yr.fsf@sopl295.home>
On Wed, Oct 19, 2022, at 23:13, Robert Jarzmik wrote:
> Arnd Bergmann <arnd@kernel.org> writes:
>
>> From: Arnd Bergmann <arnd@arndb.de>
> ...zip...
>
>> A good number of drivers become impossible to select after this, so
>> each of these also get dropped. I'm including the driver patches in the
>> series here and can either merge them through the soc tree, or they
>> can get picked up by the individual subsystem maintainers. Since both
>> the platform and the drivers get removed, the order should not matter.
> This part is a bit ... bothering.
> I at least identified these :
>> delete mode 100644 drivers/input/touchscreen/wm9705.c
>> delete mode 100644 drivers/input/touchscreen/wm9712.c
>> delete mode 100644 drivers/input/touchscreen/wm9713.c
>> delete mode 100644 drivers/input/touchscreen/wm97xx-core.c
>> delete mode 100644 drivers/mfd/wm97xx-core.c
>> delete mode 100644 sound/ac97/bus.c
>> delete mode 100644 sound/ac97/codec.c
>> delete mode 100644 sound/ac97/snd_ac97_compat.c
>
> For the existing platforms working with devicetree support (mioa701 for
> example), the wm9713 was properly used, providing both sound support and input
> touchscreen.
> So was the a97 part, providing a framework to make the wm9713 work.
>
> So I'm wondering how the choice to chop these drivers was done, and it is
> necessary to remove them. If so, maybe pxa support in the kernel should be
> removed all together, as people playing with it loose part of the working DT
> platforms they had.
If the files are used for DT based machines, then they should
definitely stay, the intention of my series was to only remove
known dead code.
What I did was to remove CONFIG_UNUSED_BOARD_FILES and then
recursively trim out all code that could be compiled in
before but not after this change, assuming that this would
be safe.
What I see here is that AC97_BUS_NEW and SND_PXA2XX_SOC_AC97
are selected by eight legacy board files (tosa, e740, e750,
e800, em_x270, palm27x, zylonite and mioa701), but no
DT based machine, so without CONFIG_UNUSED_BOARD_FILES, the
entire AC97_BUS_NEW infrastructure and all drivers depending
on this became dead code.
Unfortunately I ran into problems sending out the rest of the
series after sending the cover letter, so the explanations
I put in the individual patches were not here. See [1] for the
actual series.
Since it looks like I'll have to redo half of the PXA patches
after leaving AC97_BUS_NEW in, I won't post the full version
first.
Any idea where I went wrong here? Did I make a mistake in
following the Kconfig dependencies, or are some parts of this
incorrectly annotated?
Arnd
[1] https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove&id=73c4b7cfbc2b2
next prev parent reply other threads:[~2022-10-20 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 16:17 [PATCH 00/30] ARM: pxa: remove all unused boards&drivers Arnd Bergmann
2022-10-19 21:13 ` Robert Jarzmik
2022-10-19 21:13 ` Robert Jarzmik
2022-10-20 7:30 ` Arnd Bergmann [this message]
[not found] ` <803778517.2279639.1667493436959.JavaMail.open-xchange@opme11oxm02aub.pom.fr.intraorange>
2022-11-04 9:20 ` Arnd Bergmann
2022-10-20 7:12 ` Lee Jones
2022-10-20 7:32 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2022-10-19 15:50 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d9eebc8-39b6-4dc1-9ffc-f17ec584bee2@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@kernel.org \
--cc=balbi@kernel.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel@zonque.org \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=jarzmik.robert@orange.fr \
--cc=jingoohan1@gmail.com \
--cc=kernel@wantstofly.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@dominikbrodowski.net \
--cc=lost.distance@yahoo.com \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mkpetch@internode.on.net \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=philipp.zabel@gmail.com \
--cc=s.shtylyov@omp.ru \
--cc=slapin@ossfans.org \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=viresh.kumar@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).