From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD56C432C3 for ; Wed, 27 Nov 2019 21:30:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45DE4206F0 for ; Wed, 27 Nov 2019 21:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729471AbfK0Uzn (ORCPT ); Wed, 27 Nov 2019 15:55:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:40618 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729696AbfK0Uzn (ORCPT ); Wed, 27 Nov 2019 15:55:43 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 8DE6AAC12; Wed, 27 Nov 2019 20:55:40 +0000 (UTC) Subject: Re: [PATCH 4/5] pinctrl: sh-pfc: Use the correct style for SPDX License Identifier To: Geert Uytterhoeven , Nishad Kamdar Cc: Manivannan Sadhasivam , Sean Wang , Linus Walleij , Matthias Brugger , Kevin Hilman , Geert Uytterhoeven , Maxime Coquelin , Alexandre Torgue , Greg Kroah-Hartman , Joe Perches , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Linux ARM , linux-mediatek@lists.infradead.org, linux-gpio , linux-amlogic , Linux-Renesas , linux-stm32@st-md-mailman.stormreply.com, Linux Kernel Mailing List References: <5a7ed2e4b58ba7ff2f0638a2435a3a1e1c62c9f6.1574871463.git.nishadkamdar@gmail.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: <9bacc7d9-6bd9-0b7c-18cd-d614796397dd@suse.de> Date: Wed, 27 Nov 2019 21:55:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Geert, Am 27.11.19 um 21:37 schrieb Geert Uytterhoeven: > On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar wrote: >> This patch corrects the SPDX License Identifier style in >> header files related to Reneses Soc pinctrl driver. >> It assigns explicit block comment for the SPDX License Identifier. > > Is it incorrect to not have an explicit block comment? Yes, Greg said so to me. He suggested I provide a patch against the documentation if the docs are not clear enough, but I didn't get around to it (and it's not my rule in the first place, so I'd appreciate the person making that rule to take care of documenting it). However, if we're touching these lines anyway, shouldn't we be updating the SPDX Identifier to GPL-2.0-only while at it? Cheers, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)