linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>, Otto Meier <gf435@gmx.net>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	Kevin Hilman <khilman@baylibre.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c
Date: Thu, 12 Sep 2019 12:02:23 +0200	[thread overview]
Message-ID: <9c5b9a31-f144-b062-ba32-dacb96db3498@baylibre.com> (raw)
In-Reply-To: <CACRpkdY=Jema8LmeF_k47gQsdxTHPi5sVCYM3ihe47=bw6K4cQ@mail.gmail.com>

Hi Linus,

On 12/09/2019 11:21, Linus Walleij wrote:
> On Tue, Sep 10, 2019 at 5:01 PM Otto Meier <gf435@gmx.net> wrote:
> 
>> Hi i tried to use the uart_C of the the odroid-c2.
>>
>> I enabled it in the dts file. During boot it crashed when the
>> the sdcard slot is addressed.
>>
>> After long search in the net i found this:
>>
>> https://forum.odroid.com/viewtopic.php?f=139&t=25371&p=194370&hilit=uart_C#p177856
>>
>> After changing the pin definitions accordingly erverything works.
>> Uart_c is functioning and sdcard ist working.
>>
>>
>> Fixes: 6db0f3a8a04e46 ("pinctrl: amlogic: gxbb: add more UART pins")
>> Signed-off-by: Otto Meiergf435@gmx.net
> 
> Looks like a simple fix to me, Martin could you take a look?

Martin asked Otto to resend with a proper formatting, but seem he forgot to
CC linux-amlogic this time.

If the original mail is https://www.spinics.net/lists/linux-gpio/msg42278.html
It's Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

It was already reported in June 2018, but without a valid name for sign-off.

Neil

> 
> Yours,
> Linus Walleij
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 


  reply	other threads:[~2019-09-12 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 16:01 [BUG] wrong pinning definition or uart_c in pinctrl-meson-gxbb.c Otto Meier
2019-09-12  9:21 ` Linus Walleij
2019-09-12 10:02   ` Neil Armstrong [this message]
2019-09-14 17:25   ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c5b9a31-f144-b062-ba32-dacb96db3498@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=gf435@gmx.net \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).