From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC51C0650E for ; Thu, 4 Jul 2019 05:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F122921882 for ; Thu, 4 Jul 2019 05:02:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725811AbfGDFCI (ORCPT ); Thu, 4 Jul 2019 01:02:08 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:63674 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfGDFCI (ORCPT ); Thu, 4 Jul 2019 01:02:08 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1hitsg-00053m-Sf from Harish_Kandiga@mentor.com ; Wed, 03 Jul 2019 22:02:02 -0700 Received: from [10.0.3.15] (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 4 Jul 2019 06:01:57 +0100 Subject: Re: [PATCH V4 2/2] gpio: inverter: document the inverter bindings To: Linus Walleij , Bartosz Golaszewski , Rob Herring , Mark Rutland CC: , , Balasubramani Vivekanandan References: <1561714250-19613-1-git-send-email-harish_kandiga@mentor.com> From: Harish Jenny K N Message-ID: <9c9b8966-851a-d056-8322-f3e03f5297ad@mentor.com> Date: Thu, 4 Jul 2019 10:31:48 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <1561714250-19613-1-git-send-email-harish_kandiga@mentor.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On 28/06/19 3:00 PM, Harish Jenny K N wrote: > Document the device tree binding for the inverter gpio > controller to configure the polarity of the gpio pins > used by the consumers. > > Signed-off-by: Harish Jenny K N > --- > .../devicetree/bindings/gpio/gpio-inverter.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-inverter.txt > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-inverter.txt b/Documentation/devicetree/bindings/gpio/gpio-inverter.txt > new file mode 100644 > index 0000000..8bb6b2e > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-inverter.txt > @@ -0,0 +1,29 @@ > +GPIO-INVERTER > +====== > +This binding defines the gpio-inverter. The gpio-inverter is a driver that > +allows to properly describe the gpio polarities on the hardware. > + > +Please refer to gpio.txt for generic information regarding GPIO bindings. > + > +Required properties: > +- compatible : "gpio-inverter". > +- gpio-controller: Marks the port as GPIO controller. > +- #gpio-cells: One. This is the pin number. > +- inverted-gpios: Array of GPIO pins required from consumers, whose polarity > + has to be inverted in the driver. > +Note: gpio flag should be set as GPIO_ACTIVE_HIGH. Using GPIO_ACTICE_LOW will > +cause double inversion. > + > +Optional properties: > +- gpio-line-names: Refer to gpio.txt for details regarding this property. > + > +Example: > + > +gpio_inv: gpio-inv { > + compatible = "gpio-inverter"; > + gpio-controller; > + #gpio-cells = <1>; > + inverted-gpios = <&gpio5 24 GPIO_ACTIVE_HIGH>, > + <&gpio7 0 GPIO_ACTIVE_HIGH>, <&gpio7 1 GPIO_ACTIVE_HIGH>; > + gpio-line-names = "JTAG_DNL_EN", "lvds-pwrdwn", "lcd-on"; > +}; > -- > 2.7.4 > Can anyone of DT people please review this ? Just to let you know that Linus Walleij has reviewed the gpio inverter driver and needs some review from the DT people before he applies it. Thanks in advance. Best Regards, Harish Jenny K N