From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54B41C76191 for ; Mon, 15 Jul 2019 23:17:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DB032171F for ; Mon, 15 Jul 2019 23:17:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="NciHeA2W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731734AbfGOXRG (ORCPT ); Mon, 15 Jul 2019 19:17:06 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:43810 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731058AbfGOXRG (ORCPT ); Mon, 15 Jul 2019 19:17:06 -0400 Received: by mail-qt1-f193.google.com with SMTP id w17so17510614qto.10; Mon, 15 Jul 2019 16:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pTNuKPARTwySyUt6RIFwHeD+C8HBpvsST+SWVc23gcE=; b=NciHeA2We081hI3Qkgy7AsZ4nH44Dn6IxDoqldO6ifze6wPVXdFKbE8AM5STJCFvLJ zAzk1MW5K+j1l8Hw0gXSwU/9hPTUGMVRTKzA8V0temLm9qvAZdpESJ2GASDYsk/AcpMS ueOHQEI6JDttZMhdVRPWTHypHdvviexml1ykc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pTNuKPARTwySyUt6RIFwHeD+C8HBpvsST+SWVc23gcE=; b=NzQTGoFAHdVP2rTxjIVmrFj0LYhavgfuNuoX/R1oxdJe411D4ozjJeaPmZO6JhK4Km MpuqbMBQLCfxFiEgD13TFMfWUUY1uWQmVGZeq/4V8IbPGGScvx6yjyD+hI2OZx7wIjHC jZxY3sh3INIH3ZqbBK08dE88m/BNCJE5PACC1Ks/Mb50O0hKUfgbig6q5RxaE+8Y2Qfa pKaSA6knPXXviuckamYb64NqbpAjZ7lofqpGmVSfoRY2ix1vnSR3kALnmvaZ+r8RzJYg MVkaMK8CUCsRG0vhvhngjaXmpyWt4aGjuGuWOJTJkkzPqPeBq6DmUDkNs57OnNgrV6E5 wZ/g== X-Gm-Message-State: APjAAAVZ+mP42j6m6FZWOZ4tYPipbT3U0L9E2Trs3uJ2OkPTB72MK4m2 jCRelI6xUvCJBlswHQYW0nqGy3AkNy/d+FHs3zQ= X-Google-Smtp-Source: APXvYqxJc0v4ISkcLVlzLQuZxh/PhnbAl/t86nXT4ZSfAmxjOFMBAbcwYkAY/GLZVXs2nz+WYpc9JkkiXxXZDyNlGzw= X-Received: by 2002:ac8:2d69:: with SMTP id o38mr20058126qta.169.1563232625324; Mon, 15 Jul 2019 16:17:05 -0700 (PDT) MIME-Version: 1.0 References: <20190715223725.12924-1-robh@kernel.org> In-Reply-To: <20190715223725.12924-1-robh@kernel.org> From: Joel Stanley Date: Mon, 15 Jul 2019 23:16:54 +0000 Message-ID: Subject: Re: [PATCH] dt-bindings: pinctrl: aspeed: Fix 'compatible' schema errors To: Rob Herring Cc: devicetree , Linus Walleij , Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-gpio@vger.kernel.org, Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, 15 Jul 2019 at 22:37, Rob Herring wrote: > > The Aspeed pinctl schema have errors in the 'compatible' schema: > > Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml: \ > properties:compatible:enum: ['aspeed', 'ast2400-pinctrl', 'aspeed', 'g4-pinctrl'] has non-unique elements > Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml: \ > properties:compatible:enum: ['aspeed', 'ast2500-pinctrl', 'aspeed', 'g5-pinctrl'] has non-unique elements > > Flow style sequences have to be quoted if the vales contain ','. Fix > this by using the more common one line per entry formatting. > > properties: > compatible: > - enum: [ aspeed,ast2400-pinctrl, aspeed,g4-pinctrl ] > + enum: > + - aspeed,ast2400-pinctrl > + - aspeed,g4-pinctrl Thanks for the fix. However, we've standardised on the first form for all of our device trees, so we can drop the second compatible string from the bindings. I think Andrew already has a patch cooking to do this. Cheers, Joel