From: Linus Walleij <linus.walleij@linaro.org>
To: Joel Stanley <joel@jms.id.au>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andrew Jeffery <andrew@aj.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH] gpio: aspeed: Pass irqchip when adding gpiochip
Date: Thu, 15 Aug 2019 10:01:57 +0200 [thread overview]
Message-ID: <CACRpkdY7w2r4N62Ue-PjBMWe34DB5Xw0EPi12HetCp=rve90Xw@mail.gmail.com> (raw)
In-Reply-To: <CACPK8Xew4myVDGq5SL04kqAVeWkMdF+PsmrkutM8s-nWkJLdeA@mail.gmail.com>
On Tue, Aug 13, 2019 at 6:44 AM Joel Stanley <joel@jms.id.au> wrote:
> On Fri, 9 Aug 2019 at 12:55, Linus Walleij <linus.walleij@linaro.org> wrote:
> > + girq->parents = devm_kcalloc(&pdev->dev, 1,
> > + sizeof(*girq->parents),
> > + GFP_KERNEL);
>
> Is there a reason this is kcalloc and not kzalloc?
Following the pattern that we have one item of sizeof().
The parents can be several, so we try to follow this
pattern so people get it right.
> Acked-by: Joel Stanley <joel@jms.id.au>
Thanks!
Yours,
Linus Walleij
prev parent reply other threads:[~2019-08-15 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:55 [PATCH] gpio: aspeed: Pass irqchip when adding gpiochip Linus Walleij
2019-08-13 4:36 ` Andrew Jeffery
2019-08-13 4:44 ` Joel Stanley
2019-08-15 8:01 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY7w2r4N62Ue-PjBMWe34DB5Xw0EPi12HetCp=rve90Xw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=bgolaszewski@baylibre.com \
--cc=joel@jms.id.au \
--cc=linux-gpio@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).