Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak
@ 2019-08-08  7:43 Nishka Dasgupta
  2019-08-08  7:55 ` Baolin Wang
  2019-08-10  8:23 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Nishka Dasgupta @ 2019-08-08  7:43 UTC (permalink / raw)
  To: linus.walleij, orsonzhai, baolin.wang, zhang.lyra, linux-gpio
  Cc: Nishka Dasgupta

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
 drivers/pinctrl/sprd/pinctrl-sprd.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index c31b58168772..5abb64da2c0d 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -940,8 +940,10 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl)
 
 	for_each_child_of_node(np, child) {
 		ret = sprd_pinctrl_parse_groups(child, sprd_pctl, grp);
-		if (ret)
+		if (ret) {
+			of_node_put(child);
 			return ret;
+		}
 
 		*temp++ = grp->name;
 		grp++;
@@ -950,8 +952,11 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl)
 			for_each_child_of_node(child, sub_child) {
 				ret = sprd_pinctrl_parse_groups(sub_child,
 								sprd_pctl, grp);
-				if (ret)
+				if (ret) {
+					of_node_put(sub_child);
+					of_node_put(child);
 					return ret;
+				}
 
 				*temp++ = grp->name;
 				grp++;
-- 
2.19.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak
  2019-08-08  7:43 [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak Nishka Dasgupta
@ 2019-08-08  7:55 ` Baolin Wang
  2019-08-10  8:23 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2019-08-08  7:55 UTC (permalink / raw)
  To: Nishka Dasgupta
  Cc: Linus Walleij, Orson Zhai, Chunyan Zhang, open list:GPIO SUBSYSTEM

On Thu, 8 Aug 2019 at 15:43, Nishka Dasgupta <nishkadg.linux@gmail.com> wrote:
>
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return in
> two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>

Yes, thanks for your fix.
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>

> ---
>  drivers/pinctrl/sprd/pinctrl-sprd.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index c31b58168772..5abb64da2c0d 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -940,8 +940,10 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl)
>
>         for_each_child_of_node(np, child) {
>                 ret = sprd_pinctrl_parse_groups(child, sprd_pctl, grp);
> -               if (ret)
> +               if (ret) {
> +                       of_node_put(child);
>                         return ret;
> +               }
>
>                 *temp++ = grp->name;
>                 grp++;
> @@ -950,8 +952,11 @@ static int sprd_pinctrl_parse_dt(struct sprd_pinctrl *sprd_pctl)
>                         for_each_child_of_node(child, sub_child) {
>                                 ret = sprd_pinctrl_parse_groups(sub_child,
>                                                                 sprd_pctl, grp);
> -                               if (ret)
> +                               if (ret) {
> +                                       of_node_put(sub_child);
> +                                       of_node_put(child);
>                                         return ret;
> +                               }
>
>                                 *temp++ = grp->name;
>                                 grp++;
> --
> 2.19.1
>


-- 
Baolin Wang
Best Regards

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak
  2019-08-08  7:43 [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak Nishka Dasgupta
  2019-08-08  7:55 ` Baolin Wang
@ 2019-08-10  8:23 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-08-10  8:23 UTC (permalink / raw)
  To: Nishka Dasgupta
  Cc: Orson Zhai, Baolin Wang, Lyra Zhang, open list:GPIO SUBSYSTEM

On Thu, Aug 8, 2019 at 9:43 AM Nishka Dasgupta <nishkadg.linux@gmail.com> wrote:

> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return in
> two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>

Patch applied with Baolin's review tag.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-08  7:43 [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak Nishka Dasgupta
2019-08-08  7:55 ` Baolin Wang
2019-08-10  8:23 ` Linus Walleij

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org linux-gpio@archiver.kernel.org
	public-inbox-index linux-gpio


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/ public-inbox