From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B5C1C433FF for ; Sat, 10 Aug 2019 08:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22CC52166E for ; Sat, 10 Aug 2019 08:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RM0TYXCi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725773AbfHJIXo (ORCPT ); Sat, 10 Aug 2019 04:23:44 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:45529 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfHJIXo (ORCPT ); Sat, 10 Aug 2019 04:23:44 -0400 Received: by mail-lj1-f194.google.com with SMTP id t3so5590343ljj.12 for ; Sat, 10 Aug 2019 01:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XzBv7K5BofKX13k8kbimChFarn6qHI8jGUH0fZd1GvA=; b=RM0TYXCi62u2YBNalYl1Yx9oNk5f+6mlDWYlQu4u7msR1ktqUppznsI2ZCsUPbvl02 rgEKreizg5fAAwRNoPYaObeguxcDJejgaRqVTap0pTW85iIBhFkyNM0JZEbBi1DEKrpR aoonlICrpTDd14/w8XaYbbJPORxtgpH88cP/9LzdrFKW4nUbzNWcR6BoBWbqTqsJQSPr 0csixXN7zSmMXkdqRRF2oBjHoeowK8tfUzvyB7ol1b0rLl2aaLhA9tUv+RLYD9tHom9p sG/tc9d7oD+JPYcAzMUWfPv7Xp626egYTbULAHuryijWDmEJ3Slcu5z0gQeOzPdCHqP2 5mvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XzBv7K5BofKX13k8kbimChFarn6qHI8jGUH0fZd1GvA=; b=ap3vYsQueX8qK6s0MeTobwCy2hpdWK4Tr25hGOncXWJGOGJJqI9qC4GmY1XbOIsJZz q2okITg3C+Looiw0Yjm0/hgCLVmnLMrKp2qs7ymgGRGbRvY2CGg5xTdMmngOydrtt0qV lYXuNOJ6oDGa3nE8zjKJpYUzWI1Npgitq9byulN2Px5feOFwzDO1BGl8uC8E/y0zTywv kJqvsLQUIZZTsr2Fpf3e+0FyeyRXfCumB5wPJQ5Gjg4x1saUnLv+I4jdNm+IcaFwYZzm BDNQehJ6EkWyJLwo8OB2lOjY+TM5Wo0kEBpnliBh1nubFuwacpJxPDqt8nf/GeMF4SjL J1vA== X-Gm-Message-State: APjAAAXr7SDRAnE4SSHym84hEcep2cWpXse4f7egz6jR0IAOL7rC0nWD OgcFlzFMggErV9GGHczSWQElNDvmSlPBFenMx7OTrg== X-Google-Smtp-Source: APXvYqyOjp5TNibY5OAd1Oiq/YTAM5sw2G9c95ipznj0gScnzsuXUEDz41dZfVyu8Sga0fDqRjoUkStvriRZSB/83gg= X-Received: by 2002:a05:651c:28c:: with SMTP id b12mr8049298ljo.69.1565425422610; Sat, 10 Aug 2019 01:23:42 -0700 (PDT) MIME-Version: 1.0 References: <20190808074329.15579-1-nishkadg.linux@gmail.com> In-Reply-To: <20190808074329.15579-1-nishkadg.linux@gmail.com> From: Linus Walleij Date: Sat, 10 Aug 2019 10:23:30 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: sprd: Add of_node_put() before return to prevent memory leak To: Nishka Dasgupta Cc: Orson Zhai , Baolin Wang , Lyra Zhang , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Aug 8, 2019 at 9:43 AM Nishka Dasgupta wrote: > Each iteration of for_each_child_of_node puts the previous node, but in > the case of a return from the middle of the loop, there is no put, thus > causing a memory leak. Hence add an of_node_put before the return in > two places. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta Patch applied with Baolin's review tag. Yours, Linus Walleij