From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9241C2D0E8 for ; Fri, 27 Mar 2020 10:31:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6C4D20578 for ; Fri, 27 Mar 2020 10:31:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v8SnBAIS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgC0KbS (ORCPT ); Fri, 27 Mar 2020 06:31:18 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:43652 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbgC0KbS (ORCPT ); Fri, 27 Mar 2020 06:31:18 -0400 Received: by mail-lj1-f193.google.com with SMTP id g27so9593432ljn.10 for ; Fri, 27 Mar 2020 03:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y9GPFegNFppAtG8VfOK1hzN6DX1neujiFhmSroslZ3A=; b=v8SnBAISUhe4O2X68nvq2mTQ4IESHbhhK/DdVTGF6QQpxj+HBRN/yyyodYhymC+PzS JAFdSEC2fpQdWWwymmeF4F7Gv6hDx0LMnRAoHX2Hv/10PnazJ3ZE2H5l++8BZLS7G864 MDArlHjA1tW1RQcDzi8mNdDB6rwpORj2r3S1sxgesBj3TttPQBwKjY6oDCQRmwRnomHt T+5YUciUeMpRSj/VsI0hGrOMhNfaVUdroln9DIKVTKn7ACGvcu+rQF/w6717o6nKyw7s +K1ZRkdSA3UaQo5WtepoU2x8h1WD6bBW87YeTPBJPZ/8OeN/4SKFC77CrK09NYv4o46P 2tYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y9GPFegNFppAtG8VfOK1hzN6DX1neujiFhmSroslZ3A=; b=pfH9/wSD2ijJXPlpu80CAnVnGktnWYo8g2Ur6Xg5BOblRNanQslaIXIj5iNOlhQrPt 2LDlYg+FkFnyNTWLmQTLvPnTjdXU7Q7Dp3D9hg73rMdPxubSBQsOECqnSE9Z00Ekpi2D KaSIdD7uRE6s8eRCUJjQTIRLkAGjq8Tc9t20sdZf7b3rssgakI2+4G4mnv8yI/1YIlVG ky4Ex2GS26WRKrJ1N1ra5VcoGBKJ/L206iUp//fL7Ah6I5dXc4MbHeMqLKMNpoUxgy4X hlr7Xc19ce26wO59/BAk+Ars/FjDRoDaxYL8QRAdtakV6LEfheYbSKCP+N5f8dW7yuNT otvw== X-Gm-Message-State: ANhLgQ0jBxcVYQJmwaKchO1Mr79TpwnRWR8ymPWLbkc1N7vAUmGP/tZH GLaia9N1PAtMYAzILnXsEA2i2pCiEnuhFKBrlLhBfw== X-Google-Smtp-Source: ADFU+vvzNuB6yrUNJcqv0peX2lxUzuEUOGbmXMaFpa4JyDohIZuKl0tKEbyR5jYlOofIttkCHl7I8ntnC39UZAJQJd4= X-Received: by 2002:a05:651c:445:: with SMTP id g5mr7734981ljg.125.1585305074115; Fri, 27 Mar 2020 03:31:14 -0700 (PDT) MIME-Version: 1.0 References: <20200311090644.20287-1-tiwai@suse.de> In-Reply-To: <20200311090644.20287-1-tiwai@suse.de> From: Linus Walleij Date: Fri, 27 Mar 2020 11:31:03 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: mediatek: Use scnprintf() for avoiding potential buffer overflow To: Takashi Iwai Cc: Sean Wang , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Mar 11, 2020 at 10:06 AM Takashi Iwai wrote: > Since snprintf() returns the would-be-output size instead of the > actual output size, the succeeding calls may go beyond the given > buffer limit. Fix it by replacing with scnprintf(). > > Signed-off-by: Takashi Iwai No reaction from maintainers so patch applied. Yours, Linus Walleij