From: Linus Walleij <linus.walleij@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Subject: Re: [PATCH] gpio: crystalcove: Use irqchip template
Date: Fri, 17 Jul 2020 16:14:36 +0200 [thread overview]
Message-ID: <CACRpkdYJ=z=bE-twSXG=zARdq5zDNqpwwS8amBQs2tXVY7Osag@mail.gmail.com> (raw)
In-Reply-To: <fb6bb42b-b657-5cd7-7a58-236e10bfb547@redhat.com>
On Fri, Jul 17, 2020 at 4:02 PM Hans de Goede <hdegoede@redhat.com> wrote:
> Erm, it does not even compile:
>
> drivers/gpio/gpio-crystalcove.c: In function ‘crystalcove_gpio_probe’:
> drivers/gpio/gpio-crystalcove.c:357:10: error: ‘ch’ undeclared (first use in this function); did you mean ‘cg’?
> 357 | girq = &ch->chip.irq;
> | ^~
> | cg
> drivers/gpio/gpio-crystalcove.c:357:10: note: each undeclared identifier is reported only once for each function it appears in
>
> I've fixed this up locally.
Thanks, the SOC_PMIC isn't in the Intel default build, and you know
me and Intel ...
Sorry for that.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-07-17 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 11:25 [PATCH] gpio: crystalcove: Use irqchip template Linus Walleij
2020-07-17 13:59 ` Hans de Goede
2020-07-17 14:02 ` Hans de Goede
2020-07-17 14:14 ` Linus Walleij [this message]
2020-07-17 14:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYJ=z=bE-twSXG=zARdq5zDNqpwwS8amBQs2tXVY7Osag@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=hdegoede@redhat.com \
--cc=linux-gpio@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).