From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] pinctrl: rockchip: Avoid losing interrupts when supporting both edges Date: Thu, 8 Jan 2015 20:25:02 +0100 Message-ID: References: <1419274049-5069-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1419274049-5069-1-git-send-email-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Heiko Stuebner , Alexandru Stan , "open list:ARM/Rockchip SoC..." , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Mon, Dec 22, 2014 at 7:47 PM, Doug Anderson wrote: > I was seeing cases where I was losing interrupts when inserting and > removing SD cards. Sometimes the card would get "stuck" in the > inserted state. > > I believe that the problem was related to the code to handle the case > where we needed both rising and falling edges. This code would > disable the interrupt as the polarity was switched. If an interrupt > came at the wrong time it could be lost. > > We'll match what the gpio-dwapb.c driver does upstream and change the > interrupt polarity without disabling things. > > Signed-off-by: Doug Anderson Patch applied for fixes. Yours, Linus Walleij