From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF9F5C43381 for ; Tue, 2 Feb 2021 19:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0FB564E93 for ; Tue, 2 Feb 2021 19:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239933AbhBBThv (ORCPT ); Tue, 2 Feb 2021 14:37:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239922AbhBBTha (ORCPT ); Tue, 2 Feb 2021 14:37:30 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F3AC061788 for ; Tue, 2 Feb 2021 11:36:38 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id m22so17926429ljj.4 for ; Tue, 02 Feb 2021 11:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R4c/MM2OeFxJQCR1Po/yb9CvVRI26WIGkF2c978zb24=; b=pAiCeAfTIOpU0VtEgN2YFrXkOkFP9QnwxlCDVYDCxLN+UwFlq14HnXaBt+eaJTenk9 iCtULZalTFxA2CC0fL0ZsiavI3kKWb+ytS0Gei3NJZLvwNnG4C0IWEcu8bFyegBm7rhk OX/O/ZrKnbJ7PsmmwNIq8kuK34ds8jO8jgCN8Vph4pQdgP1FkoHgQV170oPvNm7A02Cz AujZsYeZ6WgS6V84BPbHYVbbMLOYOWl/SaB33eoJ+nkRP8Z0jjzCAMChsNR5QgLuTv/1 ycNMlVdYLVMFL6cyf/Jeu2Y115NBZcm9OVuXiyC/p3C29M4xNg8IVwVfNtjiy3hwRw6n /YwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R4c/MM2OeFxJQCR1Po/yb9CvVRI26WIGkF2c978zb24=; b=i3se6l5CjZ0GpqQeubaLIthSTxQ1cblKN4lDyOkemLjEEako/EWTJENdWi+pG65rdk dALniJPmIqoUhzik/IhigB83sWWgcABnuOOji2S8CfzlvUrqwzpJoCnHJRdjiNN9H6C9 9+GBQ5nBa6wYaVuh25GMFr8xna1Sjn2hPfXO6aZvWMtDm3/YInNahTIxs0+nI7qTDIc0 McZgWRAjt+EG/FdbM/VMdnX5S2iX0AEMAZPe3oNGz2GaI/wXTcaHcFid1IWvUapC9Sa4 +LdfjzFSgm540rpi5HvzhFs+d2Br+ANRANad3twKJ4s+QQN7u+pvLei2yVtN87Vc9Zw7 1Flw== X-Gm-Message-State: AOAM532euzFpQtvHTRONwnH3VpWEOPrT8Tls2NxPde4M2ZtIVc1iINi8 gFQTWqmnFq2U8tmztRJYvdQHwWnJ1aAu571pqZxyew== X-Google-Smtp-Source: ABdhPJzhTzTJ1uQCVb9kr69LR9RlGJOUL9l0IrxMLMaflVEsFSxIUD+PVs0yz3q00wphUieXc9ty22nBzf6H+YmzLp0= X-Received: by 2002:a2e:894d:: with SMTP id b13mr13907025ljk.438.1612294597310; Tue, 02 Feb 2021 11:36:37 -0800 (PST) MIME-Version: 1.0 References: <1611930410-25747-1-git-send-email-srinivas.neeli@xilinx.com> <1611930410-25747-4-git-send-email-srinivas.neeli@xilinx.com> In-Reply-To: <1611930410-25747-4-git-send-email-srinivas.neeli@xilinx.com> From: Linus Walleij Date: Tue, 2 Feb 2021 20:36:26 +0100 Message-ID: Subject: Re: [PATCH V5 3/5] gpio: gpio-xilinx: Add interrupt support To: Srinivas Neeli Cc: Bartosz Golaszewski , Michal Simek , Shubhrajyoti Datta , Srinivas Goud , William Breathitt Gray , Syed Nayyar Waris , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , git , Robert Hancock Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jan 29, 2021 at 3:27 PM Srinivas Neeli wrote: > Adds interrupt support to the Xilinx GPIO driver so that rising and > falling edge line events can be supported. Since interrupt support is > an optional feature in the Xilinx IP, the driver continues to support > devices which have no interrupt provided. > Depends on OF_GPIO framework for of_xlate function to translate > gpiospec to the GPIO number and flags. > > Signed-off-by: Robert Hancock > Signed-off-by: Shubhrajyoti Datta > Signed-off-by: Srinivas Neeli > --- > Changes in V5: This v5 version looks very nice to me! Reviewed-by: Linus Walleij Yours, Linus Walleij