From: Linus Walleij <linus.walleij@linaro.org>
To: "Jianqun Xu" <jay.xu@rock-chips.com>, "Heiko Stübner" <heiko@sntech.de>
Cc: David Wu <david.wu@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v2] pinctrl/rockchip: splite soc data to separated driver
Date: Wed, 15 Jan 2020 13:51:40 +0100 [thread overview]
Message-ID: <CACRpkdY_EHQbF4rRyGwoxEk8LeWfmRzmCd=8=SY95LPXMHYOmw@mail.gmail.com> (raw)
In-Reply-To: <20200113011616.19791-1-jay.xu@rock-chips.com>
On Mon, Jan 13, 2020 at 2:16 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> * Decrease codes of pinctrl-rockchip.c from 4,000 lines to 2000 by
> separating soc data to a new file.
>
> * Move rockchip pinctrl related struct definations to a head file.
>
> * Keep legency pinctrl-rockchip.c under driver/pinctrl but not to
> compile it, conveniently for reviewers.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
This patch looks good, two things are missing:
- Review from Heiko
- A change to MAINTAINERS so that the file pattern still
matches
Should someone from Rockchip also sign up as comaintainer
for this driver by the way? (Though the people at Rockchip
posting patches for this seem to change a bit.)
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-01-15 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 9:40 [PATCH] pinctrl/rockchip: splite soc data to separated driver Jianqun Xu
2020-01-10 16:19 ` kbuild test robot
2020-01-13 1:16 ` [PATCH v2] " Jianqun Xu
2020-01-15 12:51 ` Linus Walleij [this message]
2020-01-16 3:44 ` Kever Yang
2020-01-16 7:14 ` [PATCH v3] pinctrl: rockchip: split rockchip pinctrl driver by SoC type Jianqun Xu
2020-01-16 7:47 ` [PATCH v3 RESEND] " Jianqun Xu
2020-01-16 10:34 ` Robin Murphy
2020-01-17 8:13 ` [PATCH 0/2] pinctrl: rockchip: codingstyle for pinctrl-rockchip Jianqun Xu
2020-01-17 8:13 ` [PATCH 1/2] pinctrl: rockchip: new rockchip dir " Jianqun Xu
2020-01-17 8:13 ` [PATCH v4 2/2] pinctrl: rockchip: split rockchip pinctrl driver by SoC type Jianqun Xu
2020-02-15 11:11 ` Heiko Stuebner
2020-09-12 11:27 ` [PATCH 0/2] pinctrl: rockchip: codingstyle for pinctrl-rockchip Linus Walleij
2020-09-12 12:02 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY_EHQbF4rRyGwoxEk8LeWfmRzmCd=8=SY95LPXMHYOmw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=david.wu@rock-chips.com \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).