From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D245C433F5 for ; Sat, 16 Oct 2021 21:58:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DD9660F46 for ; Sat, 16 Oct 2021 21:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241053AbhJPWAI (ORCPT ); Sat, 16 Oct 2021 18:00:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241051AbhJPWAE (ORCPT ); Sat, 16 Oct 2021 18:00:04 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93E28C061766 for ; Sat, 16 Oct 2021 14:57:55 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id n8so57263371lfk.6 for ; Sat, 16 Oct 2021 14:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F8oCc0IEea9FCh4BQiGK/7pFTaDRWDhTVEP/QxC1rXA=; b=Z/HCYkVoBAG65Us8a35vC10l5Wf3GD6TnZk+hCauCiWX7KSbCwpWxDprsvyyDoVypm 7pw9J8UtPbybqCPkZjvHDbUAnj/2GhJHd21Aky2mvd8Vs6i5Jlpt7b6XgktCYyboWnu4 6ylbVzO5JO11aHmjrs3Guy9bwghGE+w0p7dzwTPbM8AVfi80wTx44s4y58jpIwptePCb mPYN/8AgkYPIBYOOlMq+Nfmg3FAjbxPBx0vSnR541+zhAo4kJfEZjs+qayTpTEHPaNDB OCbe0ao8r/cu5guTZWvAguRKCpxI4OYduVJwdEkuApsylicN3uJQVBVQ1VJSxhq+K/TG 47hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F8oCc0IEea9FCh4BQiGK/7pFTaDRWDhTVEP/QxC1rXA=; b=s8UkBuduarFVQw7NzdTX4AwEbUuYj8d1VFel0gQmsGf/MlP3ZKNyIySvQCy4j5C9rx aOTBOrc17chOj2QMfIWzpuB24koI0boX80icYKDJK43UGU/X8n/NI/g47H499WHbr0kv SuOc1IWjHvBHiGkjTIzmEow41gkkJSPqHrzZcmuXMhGDbmnfmtFqf+O54bi2nNezHpIb DANkOoqpkjoPThErR4uafmTVHbvfR/yrNWVq30+UNrwMnoR+2l8r/YGr2Mvy0f9Bt9VA EUxsDRn0UVMdGmi1x3d63o+RZffC2GZXrO+4NqLsLJRBUpD3b6o6F9dhKqbJ1ZKJ9/0n bsTQ== X-Gm-Message-State: AOAM532gNXs5G7DcAiU2/5bCH3AArlWEr64Kj1Sbu8tKQiay4TFDjCjZ JJ+tm5SIhScxUb6V9KpmrQFQDgDS6BmWvOJ5tb7InA== X-Google-Smtp-Source: ABdhPJw3tkY4ofQ0BEM0O3PhgMuQUq+ZSasUs25BatGDnf3HchYalXBN/1NxFHIYf3L6CSeI4FYavJ9uDzzI3/Sb7rU= X-Received: by 2002:a05:6512:3d27:: with SMTP id d39mr6386174lfv.229.1634421472660; Sat, 16 Oct 2021 14:57:52 -0700 (PDT) MIME-Version: 1.0 References: <5d683882-257d-87b2-20aa-0871e2902090@amd.com> <20211009033240.21543-1-nakato@nakato.io> In-Reply-To: <20211009033240.21543-1-nakato@nakato.io> From: Linus Walleij Date: Sat, 16 Oct 2021 23:57:41 +0200 Message-ID: Subject: Re: [PATCH v2] pinctrl: amd: disable and mask interrupts on probe To: Sachi King Cc: bnatikar@amd.com, Mario Limonciello , "open list:GPIO SUBSYSTEM" , "S-k, Shyam-sundar" , "Shah, Nehal-bakulchandra" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Oct 9, 2021 at 5:33 AM Sachi King wrote: > Some systems such as the Microsoft Surface Laptop 4 leave interrupts > enabled and configured for use in sleep states on boot, which cause > unexpected behaviour such as spurious wakes and failed resumes in > s2idle states. > > As interrupts should not be enabled until they are claimed and > explicitly enabled, disabling any interrupts mistakenly left enabled by > firmware should be safe. > > Signed-off-by: Sachi King This v2 version applied for fixes. Yours, Linus Walleij