From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCC7C433DB for ; Mon, 18 Jan 2021 14:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB6F422B40 for ; Mon, 18 Jan 2021 14:43:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405083AbhAROnn (ORCPT ); Mon, 18 Jan 2021 09:43:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393144AbhAROlv (ORCPT ); Mon, 18 Jan 2021 09:41:51 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 898A8C061573 for ; Mon, 18 Jan 2021 06:41:10 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id h205so24368880lfd.5 for ; Mon, 18 Jan 2021 06:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SIhA1mF+BYpThO8i2Iyz2DMFBxR5yWu2mUjR9REROfY=; b=gNacpnhbFHkDpwBHhaGHWGA3LLhitKbhOUvUv/KRjimoxCcZNhsr6Iy5M8mOD1mXHz JlxWIIy2UpK9eLy8n8+Gp27vMZmN4N45DTJei4m1JmW9MOEIw95Ulnl5+A8EZoUYORGU 1mqaj0OvgSStl+z0KxXy/mrNovipqXAXiu8avgzEDcm9DBV4bkktBi40QJ9MOwPlxLBr cNtph0/TrpFgh77VSjqh2IA42rLousGy4TGLGxZS9asRN/ql4iq7+sX/MLfJ9AcZjU3H HzlS7EGiPCCdkzcHgLohe3dcavIWUpJiTHFnArqtsSmhE0iLhDyt3mn+GY6nubCfL+9e u8Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SIhA1mF+BYpThO8i2Iyz2DMFBxR5yWu2mUjR9REROfY=; b=VgUU16l7CQ/oNPlPKkvcXYA+xk7F8rHR0TTj1FuX0ZnitSp1Tr68NQ+kppKNRzXyMP U2M3t6EECQDw9fzRr79Bo6ASaxTnHrSiH9r2Qe776/Vz6wXxX2+f4EmmRkFxgd39A+D7 f/+bXqDqd7d1T4q1I0+7kIApyQoxmoWo2xZftc4G5uNLmG6BpxngsW+W+PNPNAkWeqvb a0MBcF3ZQi8QTyxJWcTNM8WhRpGWTGS0MSRcDQjg7cNtL+zpmjvlu6sU9NzHdNh8Y+us A3JXnLBMaGaRzL1vxVG22kMJYAH31vyq9vC/2ygIQ2FqpqmvZdE1n/8Fsdkg+6Tx8RGd gqVQ== X-Gm-Message-State: AOAM533Wybu8UrANwrgDYhIdUn7AFFbHCaSkG22L0YRTVmlfv0+NjUH/ 5BMJUVRkXiXGid7bDBWzffuCd3M2btQcbdlETz4TsQ== X-Google-Smtp-Source: ABdhPJwqmgpPf8hJv9vGP5zEfW/r8eJtUSojunYR0APxeBQ1zFaQZN2Yp8arPP/uXr5O1AhiV5/uXYk3DE/AChKvJ9I= X-Received: by 2002:a05:6512:3f3:: with SMTP id n19mr11634965lfq.586.1610980869125; Mon, 18 Jan 2021 06:41:09 -0800 (PST) MIME-Version: 1.0 References: <20210113223808.31626-1-hongweiz@ami.com> <20210113223808.31626-2-hongweiz@ami.com> In-Reply-To: <20210113223808.31626-2-hongweiz@ami.com> From: Linus Walleij Date: Mon, 18 Jan 2021 15:40:57 +0100 Message-ID: Subject: Re: [PATCH, v1 1/1] gpio: aspeed: Add gpio base address reading To: Hongwei Zhang Cc: Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-aspeed , "linux-kernel@vger.kernel.org" , OpenBMC Maillist Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Jan 13, 2021 at 11:38 PM Hongwei Zhang wrote: > Add gpio base address reading in the driver; in old code, it just > returns -1 to gpio->chip.base. > > Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system") > Signed-off-by: Hongwei Zhang NAK, sorry. We never allow the device tree to specify this. First, it is a Linux-only base so it would have to be a "linux,..." property. Even if it is a Linux-only property, it is a bad idea. Only people using sysfs should have any need to specify global GPIO numbers. Don't use sysfs. Use the GPIO character device instead. See further: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpio/TODO Yours, Linus Walleij