From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v2] gpio: of: Break out OF-only code
Date: Sun, 28 Jul 2019 23:19:37 +0200 [thread overview]
Message-ID: <CACRpkdZ-ntmgneb092wdMH2-nhEFHe0TRqBoi2J9M1ZErJYpqA@mail.gmail.com> (raw)
In-Reply-To: <20190717092808.GR9224@smile.fi.intel.com>
On Wed, Jul 17, 2019 at 11:28 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> > Create a local gpiolib-of.h header and move stuff around a
> > bit to get a clean cut.
>
> Are you going to split ACPI parts as well (at least to a header)?
Yeah when I find time, unless you beat me to it :D
> One nit to address below (sorry, didn't notice before), and take mine
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks!
> > - if (!gpiochip->need_valid_mask)
> > + if (IS_ENABLED(CONFIG_OF_GPIO))
> > + gc->need_valid_mask = of_gpio_need_valid_mask(gc);
>
> gpiochip->need_valid_mask = of_gpio_need_valid_mask(gpiochip);
>
> Even with full name it fits 80.
> Can you drop renaming here?
The renaming is drive-by syntax fixing. I want to change all of these
variable to just "gc" to declutter the code. When I touch functions I
already work on I change it a bit here and there.
I'm fine with unrelated syntax and style fixes in patches to some
extent, I'm not one of those who dislike it. I just follow
Documentation/process/4.Coding.rst, given the number
of independent patches for coding style I get people seem
not to have read this at all:
"pure coding style fixes are seen as noise by the development community;
they tend to get a chilly reception. So this type of patch is best
avoided. It is natural to fix the style of a piece of code while working
on it for other reasons, but coding style changes should not be made for
their own sake."
I just accept both: separate coding style fixes and changing the
style while changing the code.
Yours,
Linus Walleij
prev parent reply other threads:[~2019-07-28 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 7:10 [PATCH v2] gpio: of: Break out OF-only code Linus Walleij
2019-07-17 9:28 ` Andy Shevchenko
2019-07-28 21:19 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ-ntmgneb092wdMH2-nhEFHe0TRqBoi2J9M1ZErJYpqA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).