From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C339C3F68F for ; Thu, 12 Dec 2019 14:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 234E721655 for ; Thu, 12 Dec 2019 14:36:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CYTDu33S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729757AbfLLOgq (ORCPT ); Thu, 12 Dec 2019 09:36:46 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34829 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729769AbfLLOgg (ORCPT ); Thu, 12 Dec 2019 09:36:36 -0500 Received: by mail-lj1-f193.google.com with SMTP id j6so2566923lja.2 for ; Thu, 12 Dec 2019 06:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mFBaysu79yDikUBKmCJOSK+/KcLNsfSxo1Kg6RMTYzo=; b=CYTDu33S/uRKGhVT7parvwID0Z4EEkvon8ISEhgQg581I+1vygWkVRJfIX6VyR90IP 5s90on/IBWtzNCkfiPg7uk+yBQZZgeRl/SRSDr7c+w33usVVyP+MJiAG1YhQEWLjO/Lm P/0CD0GARye2OYMRl25h1tC04+CXoKFn2YTnfaKWCVyq0RUQtJskTe7aNXDDUW4mR74/ t7GoesEcr1oPDRiIJXWl4xt+DmU6FKcdogFEPM7GJ0MbM1/bRU5TyZ/4OU2CRtiJtNg9 8b733kTi7YVBHa42ZnE/qE1MABlz/YuyRm0mRdXrwoA54K3MFcLxF9VgrBgIm71NLVT5 m2mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mFBaysu79yDikUBKmCJOSK+/KcLNsfSxo1Kg6RMTYzo=; b=J9+cT/rk3Ug/PeCB/FJQedb3HWo88qtNZjBHvGfbg2n40ovBGbXrT1iLt9XDGo4/sp RG0QPanyyZAYt3GZ40U2X9PeaCjQ0lk3acdXJq0+9vq5UlIbDxcXHF0bSX8eZPcoLgaT poWvGTjyvrhzQbiIhZWRWxIMIXb6DX/odpiOF68D1BtFmyeNIc9PCsiKoTKwRlXBXDoy QPkV95h8CII0GY+LjNIkLxNbwctDT72+vs9/xfl4JNZDtYTzbTX5vi6DRb3QU2H4Xn5a G8VG6vq6s8nUU1DErUdTDyyTJqATiwsLQ0ebHXl2SmDKCxdpnmVr2F26FQyZEFjAMI1E UiuA== X-Gm-Message-State: APjAAAVbDbwc+3G9SOC0Rp34vYZw1STjVcPhrNLKMJZ3loz7kjZcW57S z4XbcgaqXVFETyRGYZX4rwcfjLns0rGmP7Xtv9hPtg== X-Google-Smtp-Source: APXvYqz/zPYVnRmIpLFYccngv9dixRG8YUx2SGeQvmu/20Gvhakgo9h/gmYehDYbcCI+QIDTfrgweSqbzBJTINCecCM= X-Received: by 2002:a2e:844e:: with SMTP id u14mr6119798ljh.183.1576161394471; Thu, 12 Dec 2019 06:36:34 -0800 (PST) MIME-Version: 1.0 References: <20191127084253.16356-1-geert+renesas@glider.be> <20191127084253.16356-3-geert+renesas@glider.be> In-Reply-To: From: Linus Walleij Date: Thu, 12 Dec 2019 15:36:22 +0100 Message-ID: Subject: Re: [PATCH v3 2/7] gpiolib: Add support for gpiochipN-based table lookup To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Bartosz Golaszewski , Jonathan Corbet , Rob Herring , Mark Rutland , Harish Jenny K N , Eugeniu Rosca , Alexander Graf , Peter Maydell , Paolo Bonzini , Phil Reid , Marc Zyngier , Christoffer Dall , Magnus Damm , "open list:GPIO SUBSYSTEM" , Linux Doc Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas , "linux-kernel@vger.kernel.org" , QEMU Developers Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Dec 12, 2019 at 2:33 PM Geert Uytterhoeven wrote: > On Thu, Dec 12, 2019 at 2:20 PM Linus Walleij wrote: > > On Wed, Nov 27, 2019 at 9:43 AM Geert Uytterhoeven > > wrote: > > > Currently GPIO controllers can only be referred to by label in GPIO > > > lookup tables. > > > > > > Add support for looking them up by "gpiochipN" name, with "N" either the > > > corresponding GPIO device's ID number, or the GPIO controller's first > > > GPIO number. > > > > > > Signed-off-by: Geert Uytterhoeven > > > > What the commit message is missing is a rationale, why is this needed? > > Right. To be added: so they can be looked up in the GPIO lookup table > using either the chip's label, or the "gpiochipN" name. After reading the aggregator/forwarder driver I am not convinced that this is needed at all and I think this patch can be dropped, but check my review and see what you think! Thanks, Linus Walleij