[PATCH] pinctrl: bcm-iproc: Use SPDX header

[PATCH] pinctrl: bcm-iproc: Use SPDX header

[Linus Walleij]

This convert the BCM IPROC driver to use the SPDX header
for indicating GPL v2.0 only licensing.

Cc: Pramod Kumar <pramodku@broadcom.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index b70058caee50..18ff01727e0e 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -1,17 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright (C) 2014-2017 Broadcom
  *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation version 2.
- *
- * This program is distributed "as is" WITHOUT ANY WARRANTY of any
- * kind, whether express or implied; without even the implied warranty
- * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-/*
  * This file contains the Broadcom Iproc GPIO driver that supports 3
  * GPIO controllers on Iproc including the ASIU GPIO controller, the
  * chipCommonG GPIO controller, and the always-on GPIO controller. Basic
-- 
2.21.0

Re: [PATCH] pinctrl: bcm-iproc: Use SPDX header

[Scott Branden]

Hi Linus,

On 2019-08-12 6:04 a.m., Linus Walleij wrote:
> This convert the BCM IPROC driver to use the SPDX header
> for indicating GPL v2.0 only licensing.
>
> Cc: Pramod Kumar <pramodku@broadcom.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>   drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index b70058caee50..18ff01727e0e 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -1,17 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Copyright (C) 2014-2017 Broadcom
>    *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License as
> - * published by the Free Software Foundation version 2.
> - *
> - * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> - * kind, whether express or implied; without even the implied warranty
> - * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - */
> -
> -/*

Please leave the file description comment separate from the license 
header/copyright notices.

ie. leave the above 3 lines intact.

>    * This file contains the Broadcom Iproc GPIO driver that supports 3
>    * GPIO controllers on Iproc including the ASIU GPIO controller, the
>    * chipCommonG GPIO controller, and the always-on GPIO controller. Basic

Re: [PATCH] pinctrl: bcm-iproc: Use SPDX header

[Linus Walleij]

On Mon, Aug 12, 2019 at 5:59 PM Scott Branden
<scott.branden@broadcom.com> wrote:

> Please leave the file description comment separate from the license
> header/copyright notices.
>
> ie. leave the above 3 lines intact.

OK... Why?

Is this because you have an automated tool that likes this format:

/*
 * Copyright ...
 */

/*
 * Other stuff
 */

Or is it just a personal (perception) preference?

Yours,
Linus Walleij

Re: [PATCH] pinctrl: bcm-iproc: Use SPDX header

[Scott Branden]

On 2019-08-15 12:51 a.m., Linus Walleij wrote:
> On Mon, Aug 12, 2019 at 5:59 PM Scott Branden
> <scott.branden@broadcom.com> wrote:
>
>> Please leave the file description comment separate from the license
>> header/copyright notices.
>>
>> ie. leave the above 3 lines intact.
> OK... Why?
For consistency following the internal template we follow.
>
> Is this because you have an automated tool that likes this format:
>
> /*
>   * Copyright ...
>   */
>
> /*
>   * Other stuff
>   */
>
> Or is it just a personal (perception) preference?
Yes, we do have an automated tool which performs such scans.  And then 
we need to go in and adjust the licenses back to the format you've 
described.
>
> Yours,
> Linus Walleij