From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3928BC433DF for ; Wed, 10 Jun 2020 11:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1217F20734 for ; Wed, 10 Jun 2020 11:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eJlXWXK3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728338AbgFJL1N (ORCPT ); Wed, 10 Jun 2020 07:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728331AbgFJL1N (ORCPT ); Wed, 10 Jun 2020 07:27:13 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C134C03E96F for ; Wed, 10 Jun 2020 04:27:11 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id y11so1984642ljm.9 for ; Wed, 10 Jun 2020 04:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XvVT0Q6Hk8gXd3AYI+J/EIVEwNiVTODM/dshgyMDZU4=; b=eJlXWXK3K5XrtvFPG7WyT6EXN1A2QpNzdCQR8UdhjweohwHMPIAfLe5THR/v4OWxZW gT88jxdjvmN/se7OGh129REdPvN5JDnuhuc9sXKlF3NxbAZcJDuBD1S7in1wdtwjL0aw w7W/oyY4iyLgTrMqvZIdlx/ZjNOidsb7RfSP8uC2Rn3BecNlv6LX9NJvAA1W4iNR1ZQ/ MN9OCNDZxfg+pIbfSoGZMI99CqN8dztkduCqXhFamv1W2ZmFK89Satd4uQJQOrHcCtZW t+E+oMcDt3s+2IlY3tTiRm8zrqi1Cz9ZBJL+jfDOLEp6KfO0V8e+hsLtBpysqWbqB74X gciw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XvVT0Q6Hk8gXd3AYI+J/EIVEwNiVTODM/dshgyMDZU4=; b=TOiFFw8gybufIvbcI8F2Sal4/dkJKMCkO7JE+0Gq/HtvxsOW0ok0Xfu/YyjqhX7fkv AW37dB0APVPXnc3jLX4UuMxb/BVsQPjILr79b0b1/HrnTTF+R6PsQIsUonjM1UlKxelZ 7mhLQQjDk5iXbCCarShthbcynTjIkBI8+BPT3IhWij3rLqW5iWVb+iI1qS6PA1J8eRXU VhLyUnzlX1wvg0FcLpPaMP8lxlOuDAkrosEgiZKFQRcfic6asiTB8g3DuYWpMfctD249 Mh4DMF1GawWTDPd6h7HmRC9+QnVWqEtXaKiFsMiMuS6foskAr0gLwvUWHpnUNoBZEALD 9vEw== X-Gm-Message-State: AOAM533DZGUH81fpNpLzC3yRv/cBcZvSL9q+DMFvb5VcodXCbvWr4Egj pXlFvITH4953Hzh96Z2gilj+xQGdqrzbWpfqDFRm4w== X-Google-Smtp-Source: ABdhPJwNdb4XRg+9MmMDiZBQ2MdKsAyMHvs0gAkzW5F+xrKheuex5CzAkMV3Bl/mxWe97JW6UDqlvoZNaQDjG2HnEf0= X-Received: by 2002:a05:651c:112e:: with SMTP id e14mr1425096ljo.338.1591788429960; Wed, 10 Jun 2020 04:27:09 -0700 (PDT) MIME-Version: 1.0 References: <20200608134300.76091-1-andriy.shevchenko@linux.intel.com> <20200608134300.76091-3-andriy.shevchenko@linux.intel.com> In-Reply-To: <20200608134300.76091-3-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Wed, 10 Jun 2020 13:26:59 +0200 Message-ID: Subject: Re: [PATCH v1 2/6] gpio: dwapb: Read GPIO base from snps,gpio-base property To: Andy Shevchenko Cc: Serge Semin , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , Lee Jones Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 8, 2020 at 3:43 PM Andy Shevchenko wrote: > For backward compatibility with some legacy devices, introduce > a new property snps,gpio-base to read GPIO base. Don't advertise > to discourage users from utilizing it. > > Signed-off-by: Andy Shevchenko I usually have a very negative gut reaction to any attempts to hardcode the heavily deprecated use of the gpio_base for the global GPIO numberspace. The reason is clear from drivers/gpio/TODO I think. I need a really good explanation why this is needed, the only reason people have been pushing this in the past is "oh we are using the sysfs and we don't wanna change the GPIO numbers in our scripts" which I really want to push back on now that we have the chardev and the libgpiod utils. If this is needed for something driver internal, it should stay in a driver-local variable. Yours, Linus Walleij