From: Linus Walleij <linus.walleij@linaro.org>
To: Jacky Hu <hengqing.hu@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: amd: fix npins for uart0 in kerncz_groups
Date: Mon, 22 Jun 2020 09:36:40 +0200 [thread overview]
Message-ID: <CACRpkdZNS7JD4Po9d4TXzB=+bn9qUez-eFwUjp=cF3yE8nrE0w@mail.gmail.com> (raw)
In-Reply-To: <20200616015024.287683-1-hengqing.hu@gmail.com>
On Tue, Jun 16, 2020 at 3:50 AM Jacky Hu <hengqing.hu@gmail.com> wrote:
> uart0_pins is defined as:
> static const unsigned uart0_pins[] = {135, 136, 137, 138, 139};
>
> which npins is wronly specified as 9 later
> {
> .name = "uart0",
> .pins = uart0_pins,
> .npins = 9,
> },
>
> npins should be 5 instead of 9 according to the definition.
>
> Signed-off-by: Jacky Hu <hengqing.hu@gmail.com>
Seems like an obvious bug so patch applied for fixes.
Yours,
Linus Walleij
prev parent reply other threads:[~2020-06-22 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 1:50 [PATCH] pinctrl: amd: fix npins for uart0 in kerncz_groups Jacky Hu
2020-06-22 7:36 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZNS7JD4Po9d4TXzB=+bn9qUez-eFwUjp=cF3yE8nrE0w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=hengqing.hu@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).