From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E56CC433F5 for ; Fri, 17 Sep 2021 22:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FB846112E for ; Fri, 17 Sep 2021 22:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344773AbhIQWgV (ORCPT ); Fri, 17 Sep 2021 18:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231624AbhIQWgV (ORCPT ); Fri, 17 Sep 2021 18:36:21 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3B69C061757 for ; Fri, 17 Sep 2021 15:34:57 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id i4so39150961lfv.4 for ; Fri, 17 Sep 2021 15:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gXiGALIBXJHuI6xmyac3EY3aPT5ycKco2OHFCbsywNE=; b=Iwi25YMops4Fmva5SMYK9N2ZZvpq0vTvGG1mOZDPShDLAFmJRwvjUmyaBQq3xdy+Ed 1axjrbdlsU4TPN4zRNWSwKzClPgzmpxOySjix+X7njTv1p2vGVdAIuUxBkZELPvUCRhD Op5+FAJaOrkDYCdgzARHqnv915gqxYvX0MglO9xagVl+g53HWeySaVg1ZKyClwZIe2pl gqZCRDHOmWDMcgYvF+rC9QExMKqwvK6zg39zyRii/jrl0os7/wBPiWRw3780/IPgqvsA Kp0FCnhzX9XIWRmgrJop9dNDUklKFVEHgoifa8C4VSLjeGr3VgeSxfON95nPxaKXgUUS hmRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gXiGALIBXJHuI6xmyac3EY3aPT5ycKco2OHFCbsywNE=; b=RbWVtI5ArWf4SM6wGD3Er8XWqMw7L9afdknEi7bbTBFILIpzmPBC5xnhy4ZJVfeecZ Dbxvvdx+0FQLQoMOqKhOxQcWqYC/99slb3qBeZ5jP208e62bek7s66gFiNyk6dQ2e5Ik RbUM6PHdbc23DEtZP1qBuvtyi7m+7W62UVp7JkQoZ113zfJW4+E6PsdIaextOGZsJdCJ bVtFDQdnqhwB+XJjKqc4v7FyVTKY2RiWgfyvNQpzBgtzATQmncfiSQvvVELh80QGJxaG d6zDft9KoL3Xl0EyY4RjTiOkuRJcuZ+6vvx5TAcEgloDJgFboE6gBytd6dy8gvQ2vIS+ m29A== X-Gm-Message-State: AOAM533yWCS5zLnanp6IYQEVncyXmtuLi0LsMiINom8roLIeD9LqaO5x 1nJ6odTpMBbtJC0cu1p7+MSA21+9YQBvVKpdayfnvIK2iPo= X-Google-Smtp-Source: ABdhPJxnXIcJHvzJCDEfKvO96DDVOnEjALfnFCxyXo3w5ywzjEWk7+CQHA5Fv2Q0E9JnPHkLVI9VUW6ZkRl9/aMEDjg= X-Received: by 2002:a05:651c:11c7:: with SMTP id z7mr11241326ljo.288.1631918096195; Fri, 17 Sep 2021 15:34:56 -0700 (PDT) MIME-Version: 1.0 References: <20210913224926.1260726-1-heiko@sntech.de> <20210913224926.1260726-2-heiko@sntech.de> In-Reply-To: <20210913224926.1260726-2-heiko@sntech.de> From: Linus Walleij Date: Sat, 18 Sep 2021 00:34:45 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/rockchip: extended debounce support is only available on v2 To: Heiko Stuebner Cc: Bartosz Golaszewski , Jianqun Xu , "open list:GPIO SUBSYSTEM" , Linux ARM , "open list:ARM/Rockchip SoC..." , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 14, 2021 at 12:49 AM Heiko Stuebner wrote: > The gpio driver runs into issues on v1 gpio blocks, as the db_clk > and the whole extended debounce support is only ever defined on v2. > So checking for the IS_ERR on the db_clk is not enough, as it will > be NULL on v1. > > Fix this by adding the needed condition for v2 first before checking > the existence of the db_clk. > > This caused my rk3288-veyron-pinky to enter a reboot loop when it > tried to enable the power-key as adc-key device. > > Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller") > Signed-off-by: Heiko Stuebner Reviewed-by: Linus Walleij This can be applied by Bartosz to the GPIO subsystem. Yours, Linus Walleij