From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CCAC432C3 for ; Wed, 27 Nov 2019 10:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7DAF92073F for ; Wed, 27 Nov 2019 10:03:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XyWOIv/9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfK0KDF (ORCPT ); Wed, 27 Nov 2019 05:03:05 -0500 Received: from mail-lj1-f176.google.com ([209.85.208.176]:42463 "EHLO mail-lj1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726133AbfK0KDF (ORCPT ); Wed, 27 Nov 2019 05:03:05 -0500 Received: by mail-lj1-f176.google.com with SMTP id n5so23734765ljc.9 for ; Wed, 27 Nov 2019 02:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KE/iCdYHndFpc/Vd1E/rLvIiYAhS927Axg5oqy6mft8=; b=XyWOIv/9cJhWDHogdnraBagGV+6FiaTShU2P+EQDiYk538wtWslWxnTiQo6FX28vRQ MRlg5RlE4ug6Jp+m98l1M4R/I88wvNwLAAGgDHYcV8XliPY0//uo5cfTuANGWRavJtoA dKa7kmFlTzvsCVG6pG5ywKKysJKbWPOJMGeeXwo2oj7s9reohtwhN2D3YAbr74VFjHdu Voym/oSnX5/mOnCpS72tyjpoiLLZYYXCnsSbDi1jg5ktXc+nTu83uXr+iwcdTmXgpx56 mJWF/yFCbGR3aKMQ8PpkRVZ+XoZAzDivj3xcHLYCxuCBdi20etSWImu7qqZEhc0+sMHA y0zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KE/iCdYHndFpc/Vd1E/rLvIiYAhS927Axg5oqy6mft8=; b=AiIOu1vvsq5GWkuYtR3AxxilFGFivANQ27tRxpk0F9lWF0uoshK4xdY9T81Dpd8GHY 6tW1s7clESDWVPYMOYp7OSes0bWgGqActsUrf7N7WM6HlROsoayYBhUrPl+P36JxYsMx 7aqySRfN5sT8xRFWSZUuJqMj9NPaFzkRVF/kwQXcbQt8y7ueVkaFSb5pvDQuYH/k+c0g Lwizvp6AP3PVpqplI5yL9c2nW8sSsZ6N9XhizCcoxo/mU+j9isijFgV2XtqKmAIzS10b fFghAw04O93cQfBgCRfeht1jZuNOc9wV/VNjY6WpXHqM41Cv6ex/BgEOZJ3lggUoK9fc ZCtw== X-Gm-Message-State: APjAAAVQhVmB6boUtwMTp09EP5BJH6zPreAmPD7HF+xE8bX2eWxeuO8e azuakxPUvrDP23P6IQeChW+QsretDU4iZoyzIhMz+Q== X-Google-Smtp-Source: APXvYqzYs76Uwe+UFp5VQj1Em0o54MoZmAIAGfN8OIxLvEYlhfXcFCwZSRJbA50jOUEOA1DKlxAXUuBxKRao9wZ+SJQ= X-Received: by 2002:a2e:b4f6:: with SMTP id s22mr17669943ljm.218.1574848982885; Wed, 27 Nov 2019 02:03:02 -0800 (PST) MIME-Version: 1.0 References: <1efb797c-e3c1-25a4-0e81-78b5bbadb355@c-s.fr> <3c79a8b9-65e4-bfc9-d718-b8530fe1e672@c-s.fr> <582b5ccf-8993-6345-94d1-3c2fc94e4d4f@c-s.fr> In-Reply-To: From: Linus Walleij Date: Wed, 27 Nov 2019 11:02:51 +0100 Message-ID: Subject: Re: Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors") To: Christophe Leroy Cc: linux-spi , Mark Brown , Fabio Estevam , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Nov 27, 2019 at 10:34 AM Christophe Leroy wrote: > In the meantime, I have tried changing "gpios" by "cs-gpios" in the > device tree, and I get the following warning: (...) > [ 3.156654] WARNING: CPU: 0 PID: 1 at drivers/spi/spi-fsl-spi.c:716 > fsl_spi_cs_control+0x64/0x7c That should be this one: if (WARN_ON_ONCE(!pinfo->immr_spi_cs)) return; That happens when spi->cs_gpiod is NULL so the chipselect isn't found and assigned, and the code goes on to check the native CS and find that this isn't available either and issues the warning. That one is a bit puzzling because I know we have this working with other "cs-gpios" consumer drivers working just fine. :/ Yours, Linus Walleij