From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC2AC433E2 for ; Sat, 20 Jun 2020 21:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C872246B9 for ; Sat, 20 Jun 2020 21:04:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jffKj9+P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbgFTVET (ORCPT ); Sat, 20 Jun 2020 17:04:19 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:44490 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728907AbgFTVES (ORCPT ); Sat, 20 Jun 2020 17:04:18 -0400 Received: by mail-lj1-f193.google.com with SMTP id c17so15222512lji.11 for ; Sat, 20 Jun 2020 14:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uMfSif8lYt33+r64QbIMr/6xvgq88zcecC3Y2xRHieQ=; b=jffKj9+P2dPJBSyOULJuAU6eBWKCl+2gQgwHtfsz6jmfHRR3WF40mhzxBPXFR+c3j1 WE/4fe7XbkzFwaLQNUN0FbFefWCE6THJpVVFMNdhcYMiwViokPGEMmID+bZikNxuHXfy +FrnK1/DCpoDSqn+e0cr4SlLZE5JfYqb2yt4GxQoWoUbpMxbJ9EYEPouYmIhFEdxWLGr QtTEoyudLU2HEq0axhatbGdFhwPmk8e8NND7hb2DldelRIjj0fcsJGsrRPMH85DaNjnq 66NAjB0c7ggwbnzd++elcTCWFgqTcsmzKaytPVhCfhST2MlsbPqCIngKn0hlvWeW60fG /Y+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uMfSif8lYt33+r64QbIMr/6xvgq88zcecC3Y2xRHieQ=; b=mAGXeDqU/00iCUPP7qVVwRq/dinYoGtJhN91+QkaHc14wYRTA/cW3NSF2vNWy6YOmg OmzYzHnsYg6ZU36xlLm2OS5/JMEtoy7OhPfn49N30MofHYb0lk+W5DSrI7bwPwGuRLzg ngKHuem1nPMQFpRB17x1c7dcGAzZasAtQK8AjRRWYtj1BPiVDDImjuLf7/7b77iyMn9V ZS2DipNpd0LW+hh48SB+jCpqtaw0DzDbp2DuFncIHmGOtYzTt6g4L/7258yH2xPewYOa SfFGgmXaTndRUopbNvJrrQU170rUYdUXKt37kQdx2HZNphSW0VU8X+biVNupn7RUMzGN owrg== X-Gm-Message-State: AOAM5315iZXkYlWz9a1l4P4G52hBLDNXIXbY7z1PIYRhZCDrBU+yT1TZ KBkLuO1rCOZrXrVwhlxrvtOC+0bEJbGkFigIR9meeQ== X-Google-Smtp-Source: ABdhPJw5SuKxJji2VfElAtYt42a0GP5lNrUCmrE3LEQtLbJKkZXvQKMkGNPhUVtMQZEJummq20kBonA8zp4n1tWKaUE= X-Received: by 2002:a2e:a40f:: with SMTP id p15mr5259398ljn.286.1592686995948; Sat, 20 Jun 2020 14:03:15 -0700 (PDT) MIME-Version: 1.0 References: <1592224927-28576-1-git-send-email-rnayak@codeaurora.org> In-Reply-To: <1592224927-28576-1-git-send-email-rnayak@codeaurora.org> From: Linus Walleij Date: Sat, 20 Jun 2020 23:03:05 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable To: Rajendra Nayak Cc: Bjorn Andersson , Andy Gross , MSM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Maulik Shah , Lina Iyer Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 15, 2020 at 2:42 PM Rajendra Nayak wrote: > It would have been nice to be able to do this only for the particular > board with this design, however this change of removing gpio28 from the > pinctrl SoC file means we end up with one less wakeup capable gpio for > the entire SoC. Yeah but what about only removing it for this board in the driver then? > @@ -1122,7 +1122,7 @@ static const struct msm_pingroup sc7180_groups[] = { > static const struct msm_gpio_wakeirq_map sc7180_pdc_map[] = { > {0, 40}, {3, 50}, {4, 42}, {5, 70}, {6, 41}, {9, 35}, > {10, 80}, {11, 51}, {16, 20}, {21, 55}, {22, 90}, {23, 21}, > - {24, 61}, {26, 52}, {28, 36}, {30, 100}, {31, 33}, {32, 81}, > + {24, 61}, {26, 52}, {30, 100}, {31, 33}, {32, 81}, > {33, 62}, {34, 43}, {36, 91}, {37, 53}, {38, 63}, {39, 72}, > {41, 101}, {42, 7}, {43, 34}, {45, 73}, {47, 82}, {49, 17}, > {52, 109}, {53, 102}, {55, 92}, {56, 56}, {57, 57}, {58, 83}, Make a copy of this tuple-array and in sc7180_pinctrl_probe() set sc7180_pinctrl.wakeirq_map and .nwakeirq_map to something board specific like that: if (of_machine_is_compatible("my,board")) { sc7180_pinctrl..wakeirq_map = ... ; } Yours, Linus Walleij