Linux-GPIO Archive on
 help / color / Atom feed
From: Linus Walleij <>
To: Serge Semin <>
Cc: "open list:GPIO SUBSYSTEM" <>,
	Bartosz Golaszewski <>,
	Patrice Chotard <>,
	Alexandre TORGUE <>
Subject: Re: [PATCH] gpio: stmpe: Use irqchip template
Date: Tue, 28 Jul 2020 09:28:18 +0200
Message-ID: <> (raw)
In-Reply-To: <20200727211331.npttctrjmkfhezhn@mobilestation>

On Mon, Jul 27, 2020 at 11:13 PM Serge Semin <> wrote:

> Hmm, the GPIO-irq-chip setting are initialized after the GPIO-chip has been
> registered by calling the gpiochip_add_data() method earlier in this method.
> That means the IRQ-chip won't be created by the GPIOlib, which will introduce a
> bug. In order to fix the problem it's better to move the whole "if (irq > 0)
> {...}" clause to be executed before the gpiochip_add_data() function invocation.
> Though I could misunderstood something...

Ah what a mistake, thank you so much for looking through this patch and
spotting this! I sent a fix.

Linus Walleij

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 10:06 Linus Walleij
2020-07-27 12:32 ` Patrice CHOTARD
2020-07-27 21:13 ` Serge Semin
2020-07-28  7:28   ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-GPIO Archive on

Archives are clonable:
	git clone --mirror linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ \
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone