From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECDD8C0650F for ; Mon, 5 Aug 2019 09:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEF0020B1F for ; Mon, 5 Aug 2019 09:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OV1qyXMi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727357AbfHEJjF (ORCPT ); Mon, 5 Aug 2019 05:39:05 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34452 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726454AbfHEJjF (ORCPT ); Mon, 5 Aug 2019 05:39:05 -0400 Received: by mail-lj1-f193.google.com with SMTP id p17so78741680ljg.1 for ; Mon, 05 Aug 2019 02:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4OPoeAcP1A5mqwy6qFd8vLmNAKWAe1p53hw6o+WqWT4=; b=OV1qyXMiWvVc/Vac6X0UmU3u8pprzj0rSq71hMjBU8xtb05Rtzxm4DWYynedYvPo7J 4miDsvZc2iXNvnNzPkj979CaCqoNBgjybVRpWaUjnqcf4rDpH4j6h8XJqPODq4v4KEke hLL0elo/qlCz4TbNLtrZS26VAruHlPS0uAXMg2pG3DniVVjKfdkdVDSR0X417dJOaPnD PVr1+tSoCjAJzs5CIkykoN8PnZ+CryZEfTdAQc9KAifXH29eXDMH/nyF/jOxqUFqN35c FPVopu9gZhPADM5b67fqzwrcvD5u/kCplB6hNQ04kCnyzsguwvJ/q5J7h6+coMWLrqed 2d4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4OPoeAcP1A5mqwy6qFd8vLmNAKWAe1p53hw6o+WqWT4=; b=hHu7n/aoajNkqRhuX6PH/PuaknNLfHx5igG2R47VrKiSfD5nDWiyoZwnT7JionuCmU YiaQ+sIEI98R3JaBDYsWGFDaC798N57tfcVPH5yifV9b4++5PdBFLK48/5+e3PkSkxzY jGdKAoreycK7FuOsqOfULIyu6I52iLVgPwQ9PBPMEBHQdxhhYYZzFJA0yXtAFN64y0o2 mA2pLtYiizdcBlYWOMEI/FgsRoKDtGj1plmnpmQxnjCY0i7Tt2AQch1e5aStZcDLicYm Z7ZXpkECShQ6ePOao4z/H4otzGxSF8JI6zMPzMfhNUgjg35HYWGXHagqtqzs9HcHXeYl SSwg== X-Gm-Message-State: APjAAAUXnZhxeODSglpi/NLxLqu4I7DmXaaWcBiwsgF7IgdU11zojOKm MsORJCuE90Qh6WOG8foFyuUHiUqxxa9kADvVa61TxA== X-Google-Smtp-Source: APXvYqxLKF9i6t/614MmaviWtNy0DDQNZAvHLaTkOyZ635eFHTQY+3LCGLOTkAmzB9cPvRTg/nqwrQ2WBwcpMBU06F0= X-Received: by 2002:a2e:2c14:: with SMTP id s20mr16346425ljs.54.1564997942805; Mon, 05 Aug 2019 02:39:02 -0700 (PDT) MIME-Version: 1.0 References: <1563776607-8368-1-git-send-email-wahrenst@gmx.net> <1563776607-8368-3-git-send-email-wahrenst@gmx.net> In-Reply-To: <1563776607-8368-3-git-send-email-wahrenst@gmx.net> From: Linus Walleij Date: Mon, 5 Aug 2019 11:38:51 +0200 Message-ID: Subject: Re: [PATCH 12/18] pinctrl: bcm2835: Add support for BCM2711 pull-up functionality To: Stefan Wahren Cc: Eric Anholt , Florian Fainelli , Ray Jui , Scott Branden , Nicolas Saenz Julienne , Matthias Brugger , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Ulf Hansson , Adrian Hunter , bcm-kernel-feedback-list , Linux ARM , linux-rpi-kernel , "open list:GPIO SUBSYSTEM" , linux-mmc Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jul 22, 2019 at 8:24 AM Stefan Wahren wrote: > The BCM2711 has a new way of selecting the pull-up/pull-down setting > for a GPIO pin. The registers used for the BCM2835, GP_PUD and > GP_PUDCLKn0, are no longer connected. A new set of registers, > GP_GPIO_PUP_PDN_CNTRL_REGx must be used. This commit will add > a new compatible string "brcm,bcm2711-gpio" and the kernel > driver will use it to select which method is used to select > pull-up/pull-down. > > This patch based on a patch by Al Cooper which was intended for the > BCM7211. This is a bugfixed and improved version. > > Signed-off-by: Stefan Wahren Patch applied. I think I complained about some other version of this patch, this one looks entirely acceptable. Can we get rid of custom pull settings etc from the upstream device trees so we don't set bad examples? I have a strong urge to throw in a pr_warn() about any use of it. Yours, Linus Walleij