From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8111C433DB for ; Wed, 27 Jan 2021 21:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACA7F6146D for ; Wed, 27 Jan 2021 21:52:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235651AbhA0Vvq (ORCPT ); Wed, 27 Jan 2021 16:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbhA0VvL (ORCPT ); Wed, 27 Jan 2021 16:51:11 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E4EDC061574 for ; Wed, 27 Jan 2021 13:50:31 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id q12so4794027lfo.12 for ; Wed, 27 Jan 2021 13:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DXnYo/XJRlIPCj8X2tLXK8QJF68OekDoMODkg5Cs0to=; b=pg/6iGqfQaKlxtC68K+rAGE0l/r+jCk3jRYKTNxeIe/kGFvlAozMiF7FkhXAwDotpc sq0SEzqhWBoliRNAZ2d48vK8ONUKg36SPHiRRD2F416LQhXC3HBvWXWjLzFPZr4wJA9T w3DEUyCGwbxMwEcr7ATZqBcqPcav29/24zG57LhL5q48JBKEkCeQg/SQFgByG/CEKAFm pyJ7PUnX75Ti8dA5e+cN3b4p3CqM8uKn5lfkttlyKoCF38gcfbgWrfceE8NWN7Zgsl0v 9d0mpuMOcSA4KaT+K1A12zFgPIqKV0WxrxytOw6qwl/GQUusiCSlS30BdYDAOku9iQ4k mGBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DXnYo/XJRlIPCj8X2tLXK8QJF68OekDoMODkg5Cs0to=; b=Pk4TE2wz+lzxDHSD6f2/ta9AiJdNMW7cI5ivxXaKGBeJt/fd/DigmpvcIll6WIgkVI 78UhxtkfyQUDjjvbVhZeIAlRdPaIoXShc4uzCiIuqE3zRQ1+KUMaAUZ36VaWhrcEGV9P 4CSPSQ6dXJfPIZft2dPrj1d+l7OnkkTAVREl00mdrtvcq70KvvC+GVgYnn27SJit6h4u SR9Wtt7+AnAaIjQq6wE2FzqPChO58p61q3AcE2/ac/pcZ33Loui0xsTzBs90mBWtaeVv PQ1Lf7onwQRy2k1lBMs2JxMjpluSk8K7xMZ/MJCxgr/uFyPPZ8WPFdJmp80gBYGiVxu0 NMKA== X-Gm-Message-State: AOAM531pzf69k+eVpooM9VqDj+rb1dg2WI30hEO6m4PzXf9XTma/D4uy HoTFLHVHG9TUfg3i495ugIzD7S53VHBsAcARkAEWuw== X-Google-Smtp-Source: ABdhPJwPwhCSnEu4DJXmWxHiGV0Kg1iUL+SLH552zkH5ER3+Ncg66gbxNzy3d0LGDZ+iGDktGzsR7vteAkTwFG2AuUc= X-Received: by 2002:a19:600e:: with SMTP id u14mr2420516lfb.465.1611784229621; Wed, 27 Jan 2021 13:50:29 -0800 (PST) MIME-Version: 1.0 References: <20201228150052.2633-1-nikita.shubin@maquefel.me> <20210127104617.1173-1-nikita.shubin@maquefel.me> <20210127104617.1173-4-nikita.shubin@maquefel.me> In-Reply-To: <20210127104617.1173-4-nikita.shubin@maquefel.me> From: Linus Walleij Date: Wed, 27 Jan 2021 22:50:18 +0100 Message-ID: Subject: Re: [PATCH v2 3/9] gpio: ep93xx: Fix wrong irq numbers in port F To: Nikita Shubin Cc: Andy Shevchenko , Bartosz Golaszewski , Alexander Sverdlin , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Jan 27, 2021 at 11:46 AM Nikita Shubin wrote: > Port F irq's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE. > > So we need to specify girq->first otherwise: > > "If device tree is used, then first_irq will be 0 and > irqs get mapped dynamically on the fly" > > And that's not the thing we want. > > Signed-off-by: Nikita Shubin True, to satisfy old board file-type machines we unfortunately have to do this. Reviewed-by: Linus Walleij Yours, Linus Walleij