From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5968C432C0 for ; Wed, 27 Nov 2019 13:56:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76CA920722 for ; Wed, 27 Nov 2019 13:56:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L1ITjBOt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726603AbfK0N4f (ORCPT ); Wed, 27 Nov 2019 08:56:35 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:36332 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfK0N4e (ORCPT ); Wed, 27 Nov 2019 08:56:34 -0500 Received: by mail-vs1-f68.google.com with SMTP id m5so10573306vsj.3 for ; Wed, 27 Nov 2019 05:56:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=z9fftCSYc5ofDnoqK20/VtKJgAPcKl2ujIOcF/S6914=; b=L1ITjBOtbYPyX4bYqNRMPejtoJ1s18qQNhwlgTGoKgBjgjJvrImkddXl2Ybz0Z0Sw7 KKuViCH1qAH+Cy3qL1q0ifim1rQh39PhsYcPgP9AzmBVVez7nSardtC7Ob5uaFMWzycD 0YQpdcs/xSPaETwgzspI30wNfh+Gc8l4YoT1pW84i+NCp2q2ViOft7VQ0xpyR4CiF8F0 mUz2+iDne4e9bmtBRzOCatzcmBp2Nt7paNCW/6l+/fqBHty2RavIgkUmT6PKxeo6XqFr uBecFfkp+1QLhbxjTAkW0xLi8hR574Cr2dG7TLLsk1Ti7oNTY6Mn3l7gIbj+UKFHvYAy cpJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=z9fftCSYc5ofDnoqK20/VtKJgAPcKl2ujIOcF/S6914=; b=DP7V1N30n6fj1YSTUtJ+3UKK5N/CFRlTMd4xphndJZNtyzg/JbM/LScX22Mf2WNwgS tKStnT+3N07dGHFHhfn3JL/6VF1byFkJ3tg1008ngF9MnZ/VxTqmPjDQs2N0f1h7GUgN X6+rgG6K4EulYTmdkUUF/BjEGTyjStT3SA/vPmTNBL1p7FRIA4rWAgD8QE7VGGeKs5/I Aiw4OZKg/tcnmcmtqUFpzja6CJHEwgWYNjchAEwvwoJ7ZDjh2VWCS0dEpijQWOh1NaZ9 tPF+hAg9iM8m546E0DF3pKmQySCoMzE50Y57QPZZXrs8i6WxcC5cHGN4N6JyPGlcxU0B XtcA== X-Gm-Message-State: APjAAAWsS4+z8zMaKP1tKaf8mCczmaT98gT+ZPFQMCEMumQgbNtGgAWi FOLpESWBeg7zcLfqBFDlEwSxY7deTgvPmt+aER5ScA== X-Google-Smtp-Source: APXvYqxGad2QoQOM5rAGChyibn9jgxf2zm1Q9YO8riiD/EDeK5oC6QjH2wftPylo8R+RrIcwmNMVuSg+0ryA8QkT+5o= X-Received: by 2002:a67:8703:: with SMTP id j3mr4160640vsd.99.1574862993814; Wed, 27 Nov 2019 05:56:33 -0800 (PST) MIME-Version: 1.0 References: <1efb797c-e3c1-25a4-0e81-78b5bbadb355@c-s.fr> <3c79a8b9-65e4-bfc9-d718-b8530fe1e672@c-s.fr> <582b5ccf-8993-6345-94d1-3c2fc94e4d4f@c-s.fr> <748eb503-b692-6d30-bc5e-94539a939b06@c-s.fr> <8b50ce56-0600-373d-178c-92aa780e5376@c-s.fr> <99f48a7e-e4f4-2a77-657c-452d7a656ec5@c-s.fr> In-Reply-To: <99f48a7e-e4f4-2a77-657c-452d7a656ec5@c-s.fr> From: Linus Walleij Date: Wed, 27 Nov 2019 14:56:22 +0100 Message-ID: Subject: Re: Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors") To: Christophe Leroy Cc: linux-spi , Mark Brown , Fabio Estevam , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Nov 27, 2019 at 2:54 PM Christophe Leroy wrote: > Le 27/11/2019 =C3=A0 14:52, Linus Walleij a =C3=A9crit : > > On Wed, Nov 27, 2019 at 2:45 PM Christophe Leroy > > wrote: > >> Le 27/11/2019 =C3=A0 14:00, Linus Walleij a =C3=A9crit : > > > >>> Try to remove the "spi-cs-high" bool flag from your nodes, > >>> because it seems like the old code was ignoring them. > >>> > >>> Does that solve the problem? > >> > >> Yes it does. Many thanks. I let you manage the packaging of fixes. > > > > OK I will send a final batch of 3 patches fixing this. > > > > Do you have these old device trees deployed so that we > > also need to make sure that old device trees that have this > > ambigous syntax will force precendence for the flag on the > > GPIO line if both are specified for the "fsl,spi" instances? > > > > No, we deliver device trees together with Linux kernel (embedded in an > Uboot ITS/ITB image) so no worry on old device trees. OK thanks! I sent three patches, can you apply them on a clean tree and confirm it solves the problem (fingers crossed...) Thanks a lot for helping me fix this! Yours, Linus Walleij