From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F31C43331 for ; Fri, 27 Mar 2020 10:21:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79F3620714 for ; Fri, 27 Mar 2020 10:21:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BWdcmcSO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgC0KVK (ORCPT ); Fri, 27 Mar 2020 06:21:10 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:39005 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbgC0KVJ (ORCPT ); Fri, 27 Mar 2020 06:21:09 -0400 Received: by mail-lf1-f65.google.com with SMTP id h6so1614578lfp.6 for ; Fri, 27 Mar 2020 03:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TuB8BNTEMS6Xu4xWKK0GTpM0KTFJDSPd7CoTH260LEY=; b=BWdcmcSOZAia9WokqOKv83FwargH+rfDXr2Mp0QwyZsT/mABCSd3y3ZMISvNsbmXhU gQMIR1duY1UxdvKr1tbHQzNudMLJvKqINJWtOlrbk9+kwOmXToR95IOMrI3yVrYmqYw4 ERIXKr3kSqBiWHHSNhbcDl9Iko5A1Q0USZ7lVRGh7i4ZWuu8E4UBLvEJ0Rb7XNIkfIsy aw8uoNh4prsuenO/RPpdtz/llUkVRpSahQ6WFiqcc4YqGBOhRx5YxeATNzXZkpF5gRXs u9qzGndEeTvD5XvNeditQ2MMZ58/zYFaGXYoaCpP0AzoqV0GaxsvyztxFYEj52lAcoCH pBJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TuB8BNTEMS6Xu4xWKK0GTpM0KTFJDSPd7CoTH260LEY=; b=QOsRZrxqsskMuDMOSO1u9yUPDVdCCcFicMwwG/IzkYhY5TsZ8MIYGoBZL/gIoiTCN+ Pq+VfrQMO1gt0m6L7+LqtjjeA0jLa60ISS0x7CErRwU1/uCgEVnIDAvwSPGbMlp2smmn PQ4XiM0pKpbXXcnkfdklNGs4+Dj0alpYRx5yY/z+/0G2Xyo1TJb6BIT3N4qGfOWcq2dO 57+wSwiiwPyWo1q2z8hEz2ZjY4AV+XSB7lNuVD2POs3ASS/3tM5XunoxJe7kCwkiQHsJ aoJfUJzlPlEfsa/mDUt5pdk1ENFWYBLmG5+f08GloiDL7c+MSR4K5HHgZfroAIb3I0t3 xMgg== X-Gm-Message-State: ANhLgQ0ASRL899bX85rDoirCz3zPLPv21y1iChrRdX6Q4H/TBCp1TaFW 8qriT8UvbEpSEokY+/hXQ/gt9BlZ97UbJCvd/uHk76rNxqg= X-Google-Smtp-Source: ADFU+vtsIgqK8FyZODtKNKWKI1HxhtKduwTybRXQvKGmxQLsPLeMOqx9p3y4gdOqstKYu6oc3bIWeFZeiamysR3lBHg= X-Received: by 2002:a19:ac8:: with SMTP id 191mr8675462lfk.77.1585304468041; Fri, 27 Mar 2020 03:21:08 -0700 (PDT) MIME-Version: 1.0 References: <20200317205017.28280-1-michael@walle.cc> <20200317205017.28280-13-michael@walle.cc> <9c310f2a11913d4d089ef1b07671be00@walle.cc> <22944c9b62aa69da418de7766b7741bd@walle.cc> In-Reply-To: <22944c9b62aa69da418de7766b7741bd@walle.cc> From: Linus Walleij Date: Fri, 27 Mar 2020 11:20:56 +0100 Message-ID: Subject: Re: [PATCH 12/18] gpio: add support for the sl28cpld GPIO controller To: Michael Walle Cc: Bartosz Golaszewski , linux-gpio , linux-devicetree , LKML , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, LINUXWATCHDOG , arm-soc , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Mar 26, 2020 at 9:06 PM Michael Walle wrote: > Am 2020-03-25 12:50, schrieb Bartosz Golaszewski: > > In that case maybe you should use the disable_locking option in > > regmap_config and provide your own callbacks that you can use in the > > irqchip code too? > > But how would that solve problem (1). And keep in mind, that the > reqmap_irqchip is actually used for the interrupt controller, which > is not this gpio controller. > > Ie. the interrupt controller of the sl28cpld uses the regmap_irqchip > and all interrupt phandles pointing to the interrupt controller will > reference the toplevel node. Any phandles pointing to the gpio > controller will reference the GPIO subnode. Ideally we would create something generic that has been on my mind for some time, like a generic GPIO regmap irqchip now that there are a few controllers like that. I don't know how feasible it is or how much work it would be. But as with GPIO_GENERIC (for MMIO) it would be helpful since we can then implement things like .set_multiple() and .get_multiple() for everyone. Yours, Linus Walleij