From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1] gpio: pca953x: Fix GPIO resource leak on Intel Galileo Gen 2
Date: Sat, 20 Jun 2020 23:31:33 +0200 [thread overview]
Message-ID: <CACRpkdbWMS+qNQFsJ+9QrphTcqw+2EVRw177X0wTvTLoaXNuyQ@mail.gmail.com> (raw)
In-Reply-To: <20200618114906.79346-1-andriy.shevchenko@linux.intel.com>
On Thu, Jun 18, 2020 at 1:49 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> When adding a quirk for IRQ on Intel Galileo Gen 2 the commit ba8c90c61847
> ("gpio: pca953x: Override IRQ for one of the expanders on Galileo Gen 2")
> missed GPIO resource release. We can safely do this in the same quirk, since
> IRQ will be locked by GPIO framework when requested and unlocked on freeing.
>
> Fixes: ba8c90c61847 ("gpio: pca953x: Override IRQ for one of the expanders on Galileo Gen 2")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
This seems to go on top of what Bartosz applied so I expect him to pick
it up!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-06-20 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 11:49 [PATCH v1] gpio: pca953x: Fix GPIO resource leak on Intel Galileo Gen 2 Andy Shevchenko
2020-06-18 11:57 ` Mika Westerberg
2020-06-20 21:31 ` Linus Walleij [this message]
2020-06-21 8:23 ` Andy Shevchenko
2020-06-22 16:52 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbWMS+qNQFsJ+9QrphTcqw+2EVRw177X0wTvTLoaXNuyQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).