From: Linus Walleij <linus.walleij@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: Allow name duplicates of "" and "NC"
Date: Wed, 16 Dec 2020 21:50:19 +0100 [thread overview]
Message-ID: <CACRpkdbXRHCDGX-YBbNY7cMob0dZNhi1ETA3QnC71ZtOYB30JQ@mail.gmail.com> (raw)
In-Reply-To: <X9pUjU6hPI1cKS3H@builder.lan>
On Wed, Dec 16, 2020 at 7:40 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> > I think I will conjure a patch allowing identical naming only for
> > device property naming (like from device tree) but emitting a
> > warning so that people fix it to something unique moving
> > forward.
> >
>
> I'm not against emitting a dev_err() when we hit duplicates, remove the
> return and then update the various dts files to use "" for things that
> doesn't have a name.
>
> Regarding special handling of the DT case, I think (beyond making all
> these boards boot again) it would be nice to make
> gpiochip_set_desc_names() take the list of names and a length and use
> the same function in both code paths...
>
> PS. strlen(names[i]) is O(N), strcmp(names[i], "") is O(1).
OK I'll think of something. I'm pulling these patches out of the stuff
for this merge window because they are clearly immature,
nobody else is telling me so I have to realize it myself, it takes
like three days for me to do that...
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-12-16 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 17:03 [PATCH] gpiolib: Allow name duplicates of "" and "NC" Bjorn Andersson
2020-12-15 17:42 ` Bartosz Golaszewski
2020-12-15 17:59 ` Bjorn Andersson
2020-12-16 12:46 ` Linus Walleij
2020-12-16 18:40 ` Bjorn Andersson
2020-12-16 20:50 ` Linus Walleij [this message]
2020-12-16 19:53 ` Drew Fustini
2020-12-16 20:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbXRHCDGX-YBbNY7cMob0dZNhi1ETA3QnC71ZtOYB30JQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).