From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84E4C433DF for ; Mon, 3 Aug 2020 23:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9BA620786 for ; Mon, 3 Aug 2020 23:23:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ekvkT2Ee" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729026AbgHCXX2 (ORCPT ); Mon, 3 Aug 2020 19:23:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbgHCXX0 (ORCPT ); Mon, 3 Aug 2020 19:23:26 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 792B2C06174A for ; Mon, 3 Aug 2020 16:23:25 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id w25so6058295ljo.12 for ; Mon, 03 Aug 2020 16:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iIqkaLsmRYNwvI6bANOrm3GY7t2TYOib7K7xtc0Wnx8=; b=ekvkT2EenRR1kmAkT6UQ9M/f2BfPNY/k7bzVRiOSaH8nhlJEjF17GKclZ4IfW+5bko fvzPAqqBfIePDWUc6FZ+AUsfn/03vAzON+BkgNVZC7zp98Ayp1EbOImCwIiQKE2ZrOc1 7rpm7BrRXeVXUDJE2mzyUpbRPj9r+46ThGxQ2xj7ZaOQh0I8jiJtSv/rvZdr/BWs/Rmd 6FMC3Xo2piygZJy9W38tVIx9+pC+wX13ftICj8HA+M44U5356voiWpEpQ0SaLLkKEgmo fgf+LKy0okYBqwhp1arfSMfzBJKbjfWUd3nDTZDeXSJ8yTnScrmBuE5TvQhUgBTt67RE wzvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iIqkaLsmRYNwvI6bANOrm3GY7t2TYOib7K7xtc0Wnx8=; b=LUx4JXiTOymxmudeN9WIomVqcsOr9SK4P4O2wfegapPgZiR7Uxd7mhxKjUJP01nHqr NUyMglwmkUaTTAHwkrfyKEXY3Nipx4nn6Z46qrZj519DHH6zhQN3ObSnKkDSjCHnPNbh ElinkWcKVnwJrxPiq73Djc4zAtAbHKgaUSEUcb7hetGPmpNScza31r5Cr3Q4YHioRbNi Ek22xliJ29C2MTQHTG/osR2rEnOllUkRf4hMkrIVnErXd3Fe9ea/WCi7HSAxCfVk3csu 9VmQbmoNkTgrGsQ5Qzp9QHVtoNxAjJK4h3Fp8L5ftx8RqmF64kdGc98kmESHyX62otYH EGAQ== X-Gm-Message-State: AOAM530icL4CB3Gh6IN5yNYoSV9gaLIZl4zdlJwU4g1A90n7QQzpjo8/ 8BGL4NAXYOsK8l6fTn/d7dy4Zf2sS4bEDqEyHrIxAGQfGxg= X-Google-Smtp-Source: ABdhPJy993KCvqmJ6qcVxr7LQlERMXDim7CepdvPMvnSY0k2p0mtfSTk1djJW/0pxxuNiCxxXGo/UQippmenT+ukDcI= X-Received: by 2002:a2e:b80b:: with SMTP id u11mr5428827ljo.286.1596497002032; Mon, 03 Aug 2020 16:23:22 -0700 (PDT) MIME-Version: 1.0 References: <20200731123835.8003-1-a.fatoum@pengutronix.de> In-Reply-To: <20200731123835.8003-1-a.fatoum@pengutronix.de> From: Linus Walleij Date: Tue, 4 Aug 2020 01:23:11 +0200 Message-ID: Subject: Re: [PATCH] gpio: don't use same lockdep class for all devm_gpiochip_add_data users To: Ahmad Fatoum Cc: Bartosz Golaszewski , Grygorii Strashko , Thierry Reding , Sascha Hauer , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jul 31, 2020 at 2:39 PM Ahmad Fatoum wrote: > Commit 959bc7b22bd2 ("gpio: Automatically add lockdep keys") documents > in its commits message its intention to "create a unique class key for > each driver". > > It does so by having gpiochip_add_data add in-place the definition of > two static lockdep classes for LOCKDEP use. That way, every caller of > the macro adds their gpiochip with unique lockdep classes. > > There are many indirect callers of gpiochip_add_data, however, via > use of devm_gpiochip_add_data. devm_gpiochip_add_data has external > linkage and all its users will share the same lockdep classes, which > probably is not intended. > > Fix this by replicating the gpio_chip_add_data statics-in-macro for > the devm_ version as well. > > Fixes: 959bc7b22bd2 ("gpio: Automatically add lockdep keys") > Signed-off-by: Ahmad Fatoum > --- > This doesn't fix any particular problem I ran into, but the code > looked buggy, at least to my lockdep-user-not-developer eyes. Thanks patch applied, I think we had this fixed before but managed to loose it in some API rewrite. Thanks for fixing it up! Yours, Linus Walleij