Linux-GPIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -mmotm] pinctrl: mediatek: fix build for tristate changes
@ 2020-07-28  5:55 Randy Dunlap
  2020-07-28  8:20 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-07-28  5:55 UTC (permalink / raw)
  To: LKML, linux-mediatek, Sean Wang, Linus Walleij, linux-gpio,
	Andrew Morton

From: Randy Dunlap <rdunlap@infradead.org>

Export mtk_is_virt_gpio() for the case when
CONFIG_PINCTRL_MTK=y
CONFIG_PINCTRL_MTK_V2=y
CONFIG_PINCTRL_MTK_MOORE=y
CONFIG_PINCTRL_MTK_PARIS=m

to fix this build error:

ERROR: modpost: "mtk_is_virt_gpio" [drivers/pinctrl/mediatek/pinctrl-paris.ko] undefined!

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Sean Wang <sean.wang@kernel.org>
Cc: linux-mediatek@lists.infradead.org
---
 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2020-0727-1818.orig/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ mmotm-2020-0727-1818/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -264,6 +264,7 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl
 
 	return virt_gpio;
 }
+EXPORT_SYMBOL_GPL(mtk_is_virt_gpio);
 
 static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
 			     unsigned int *gpio_n,


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -mmotm] pinctrl: mediatek: fix build for tristate changes
  2020-07-28  5:55 [PATCH -mmotm] pinctrl: mediatek: fix build for tristate changes Randy Dunlap
@ 2020-07-28  8:20 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-07-28  8:20 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: LKML, moderated list:ARM/Mediatek SoC support, Sean Wang,
	linux-gpio, Andrew Morton

On Tue, Jul 28, 2020 at 7:55 AM Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
>
> Export mtk_is_virt_gpio() for the case when
> CONFIG_PINCTRL_MTK=y
> CONFIG_PINCTRL_MTK_V2=y
> CONFIG_PINCTRL_MTK_MOORE=y
> CONFIG_PINCTRL_MTK_PARIS=m
>
> to fix this build error:
>
> ERROR: modpost: "mtk_is_virt_gpio" [drivers/pinctrl/mediatek/pinctrl-paris.ko] undefined!
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sean Wang <sean.wang@kernel.org>
> Cc: linux-mediatek@lists.infradead.org

Good catch!

Thanks Randy, patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28  5:55 [PATCH -mmotm] pinctrl: mediatek: fix build for tristate changes Randy Dunlap
2020-07-28  8:20 ` Linus Walleij

Linux-GPIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-gpio/0 linux-gpio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-gpio linux-gpio/ https://lore.kernel.org/linux-gpio \
		linux-gpio@vger.kernel.org
	public-inbox-index linux-gpio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-gpio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git