From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F93C43217 for ; Wed, 19 Oct 2022 15:53:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232569AbiJSPxW (ORCPT ); Wed, 19 Oct 2022 11:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232689AbiJSPxH (ORCPT ); Wed, 19 Oct 2022 11:53:07 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC4213C3CC for ; Wed, 19 Oct 2022 08:50:13 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a26so40598128ejc.4 for ; Wed, 19 Oct 2022 08:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=oCxur44GiGn0KEf47+NGc2flFZLTxOPMJcgB85rch6w=; b=Af1ORI7qLHGJw4ifz/2FBCp+Nq0eizmGhWVnbLOtKaMLO9xPtn7WgrxQFzTVHlGfI1 2lFZJu+P2cn2W4CKzeUJnS3n2wUNZDghZrIxPpbENfO1w+DMF4ypDyyfQGvc9uuprFoe GBgp+bgwLUw6X0CUrZCNNCVIWXh2uD4Y7879s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oCxur44GiGn0KEf47+NGc2flFZLTxOPMJcgB85rch6w=; b=w8fgvewzDYv4E3Iw2HvBAm4CT578LH/wRleVs3IEGg0UfhVDzgvltDDF4Wr+Kvg4GI WWpZ2+CXlU9LpOjm1K9N993e96HWbk6fzPBdwoXZ+migGHHLLGrzFzgfEp/LXleTCVSW q0qQFc45OYq00lmmDUmy6m71SPgUS+lPB7X+5PC0dZ+S0UQlqSRS+k6Ny+Z0FZ6z46Aa vb5vkzEU+mBDBYflgyL30kL0TOV51Jh9WFBTmdQDxEg/IyuwvctB1DBcL0ARBS28lJ91 Hh3eg+9TcH7i/b6NLtOr5WgrNEGNnwvROMLkq1l3KnFFaltBfvfmoVtpcIwYyF81pqdE COQw== X-Gm-Message-State: ACrzQf1NtcJWn87LgSpK5xx/+fWvV6nVoYO5eDoeghgdiVzo938OXjtU iHtx9Lwv6zv7iN94HUFZsZxD9P8g6j7MLz0/ X-Google-Smtp-Source: AMsMyM5KQOAKlnW5Q8UnKUNqgPJjQZ5F8ka3IvJ2VrbwOl53mCNfDv+r03xqtz56XBRlfRdp9iWIuA== X-Received: by 2002:a17:907:94d1:b0:790:65a:3a18 with SMTP id dn17-20020a17090794d100b00790065a3a18mr7151570ejc.428.1666194530177; Wed, 19 Oct 2022 08:48:50 -0700 (PDT) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com. [209.85.128.44]) by smtp.gmail.com with ESMTPSA id r1-20020a1709061ba100b0072a881b21d8sm9088928ejg.119.2022.10.19.08.48.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 08:48:48 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id bg9-20020a05600c3c8900b003bf249616b0so304513wmb.3 for ; Wed, 19 Oct 2022 08:48:48 -0700 (PDT) X-Received: by 2002:a05:600c:19c9:b0:3c2:7fff:a689 with SMTP id u9-20020a05600c19c900b003c27fffa689mr27767365wmq.85.1666194527713; Wed, 19 Oct 2022 08:48:47 -0700 (PDT) MIME-Version: 1.0 References: <20221019001351.1630089-1-krzysztof.kozlowski@linaro.org> <20221019001351.1630089-4-krzysztof.kozlowski@linaro.org> In-Reply-To: <20221019001351.1630089-4-krzysztof.kozlowski@linaro.org> From: Doug Anderson Date: Wed, 19 Oct 2022 08:48:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/4] arm64: dts: qcom: sc7180: align TLMM pin configuration with DT schema To: Krzysztof Kozlowski Cc: Bjorn Andersson , Andy Gross , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Kaehlcke , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On Tue, Oct 18, 2022 at 5:14 PM Krzysztof Kozlowski wrote: > > DT schema expects TLMM pin configuration nodes to be named with > '-state' suffix and their optional children with '-pins' suffix. > > Merge subnodes named 'pinconf' and 'pinmux' into one entry, add function > where missing (required by bindings for GPIOs) and reorganize overriding > pins by boards. > > Split the SPI and UART configuration into separate nodes > 1. SPI (MOSI, MISO, SCLK), SPI chip-select, SPI chip-select via GPIO, > 2. UART per each pin: TX, RX and optional CTS/RTS. > > This allows each board to customize them easily without adding any new > nodes. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v2: > 1. Rebase on reverted SPI CS glitch patch. > > Changes since v1: > 1. Split SPI and UART nodes, after discussion with Doug. > > Not tested on hardware. > > Cc: Doug Anderson > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 236 +++---- > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 36 +- > .../dts/qcom/sc7180-trogdor-homestar.dtsi | 47 +- > .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 16 +- > .../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 8 +- > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 16 +- > .../dts/qcom/sc7180-trogdor-mrbland-rev0.dtsi | 25 +- > .../boot/dts/qcom/sc7180-trogdor-mrbland.dtsi | 72 +- > .../qcom/sc7180-trogdor-parade-ps8640.dtsi | 32 +- > .../boot/dts/qcom/sc7180-trogdor-pazquel.dtsi | 8 +- > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 14 +- > .../qcom/sc7180-trogdor-quackingstick.dtsi | 56 +- > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 8 +- > .../dts/qcom/sc7180-trogdor-ti-sn65dsi86.dtsi | 16 +- > .../qcom/sc7180-trogdor-wormdingler-rev0.dtsi | 25 +- > .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 72 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 629 +++++++----------- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 597 +++++++++-------- > 18 files changed, 776 insertions(+), 1137 deletions(-) You probably should send a v4 since this now conflicts with commit c24c9d53e001 ("arm64: dts: qcom: correct white-space before {"), which has landed. In any case, this looks nice to me. Reviewed-by: Douglas Anderson FWIW I put this on a sc7180-trogdor-coachz and the device booted up to the browser. I didn't do massive amounts of tests, but I'm OK with: Tested-by: Douglas Anderson