From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Clément Leger" <cleger@kalray.eu>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list, GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/5] gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h
Date: Wed, 4 Dec 2019 19:44:36 +0200 [thread overview]
Message-ID: <CAHp75Vc4qPeVmzgn8fn+EweoSoKveK5tDS=RwmfASojDcxuWBA@mail.gmail.com> (raw)
In-Reply-To: <1746901411.95313623.1575466785578.JavaMail.zimbra@kalray.eu>
On Wed, Dec 4, 2019 at 3:39 PM Clément Leger <cleger@kalray.eu> wrote:
> Ok, should I fix the original driver first and then submit the serie to add pinctrl ?
I guess so. Because we definitely don't want a churn with exporting
symbols like this.
> ----- On 4 Dec, 2019, at 13:35, Andy Shevchenko andy.shevchenko@gmail.com wrote:
> > On Wed, Dec 4, 2019 at 12:13 PM Clement Leger <cleger@kalray.eu> wrote:
> >>
> >> dwapb-gpio driver which uses this function will be moved to pinctrl for
> >> pinctrl support. Export this function in gpio/driver.h to allow using
> >> it.
> > I don't think this is proper way to do it.
> > The driver has to register IRQ chip and GPIO core will take care of
> > ACPI related stuff.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-12-04 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 10:10 [PATCH 1/5] gpio: export acpi_gpiochip_request_interrupts in gpio/driver.h Clement Leger
2019-12-04 12:35 ` Andy Shevchenko
2019-12-04 13:39 ` Clément Leger
2019-12-04 17:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vc4qPeVmzgn8fn+EweoSoKveK5tDS=RwmfASojDcxuWBA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=cleger@kalray.eu \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).